RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 09:17:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Tests/LibWeb/Layout/expected/flex-column-item-with-auto-height-and-max-width.txt
View file

@ -1,26 +1,26 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x92.21875 [BFC] children: not-inline
Box <body> at (2,2) content-size 796x90.21875 flex-container(column) [FFC] children: not-inline
BlockContainer <main> at (3,3) content-size 400x88.21875 flex-item [BFC] children: inline
line 0 width: 346.984375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 41, rect: [3,3 346.984375x17.46875]
BlockContainer <html> at (1,1) content-size 798x89 [BFC] children: not-inline
Box <body> at (2,2) content-size 796x87 flex-container(column) [FFC] children: not-inline
BlockContainer <main> at (3,3) content-size 400x85 flex-item [BFC] children: inline
line 0 width: 346.984375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 41, rect: [3,3 346.984375x17]
"For my day job I'm currently working as a"
line 1 width: 337.59375, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 42, length: 39, rect: [3,20 337.59375x17.46875]
line 1 width: 337.59375, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 42, length: 39, rect: [3,20 337.59375x17]
"Software Engineer at For my day job I'm"
line 2 width: 368.203125, height: 18.40625, bottom: 53.34375, baseline: 13.53125
frag 0 from TextNode start: 82, length: 43, rect: [3,37 368.203125x17.46875]
line 2 width: 368.203125, height: 17, bottom: 51, baseline: 13.296875
frag 0 from TextNode start: 82, length: 43, rect: [3,37 368.203125x17]
"currently working as a Software Engineer at"
line 3 width: 346.984375, height: 17.875, bottom: 70.28125, baseline: 13.53125
frag 0 from TextNode start: 126, length: 41, rect: [3,55 346.984375x17.46875]
line 3 width: 346.984375, height: 17, bottom: 68, baseline: 13.296875
frag 0 from TextNode start: 126, length: 41, rect: [3,54 346.984375x17]
"For my day job I'm currently working as a"
line 4 width: 175.40625, height: 18.34375, bottom: 88.21875, baseline: 13.53125
frag 0 from TextNode start: 168, length: 20, rect: [3,72 175.40625x17.46875]
line 4 width: 175.40625, height: 17, bottom: 85, baseline: 13.296875
frag 0 from TextNode start: 168, length: 20, rect: [3,71 175.40625x17]
"Software Engineer at"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x94.21875]
PaintableBox (Box<BODY>) [1,1 798x92.21875]
PaintableWithLines (BlockContainer<MAIN>) [2,2 402x90.21875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x91]
PaintableBox (Box<BODY>) [1,1 798x89]
PaintableWithLines (BlockContainer<MAIN>) [2,2 402x87]
TextPaintable (TextNode<#text>)