RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:57:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Tests/LibWeb/Layout/expected/flex-item-auto-height-with-wrap.txt
View file

@ -1,10 +1,10 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x116 [BFC] children: not-inline
Box <body.outer> at (8,8) content-size 400x100 flex-container(column) [FFC] children: not-inline
Box <div.inner> at (8,8) content-size 400x17.46875 flex-container(row) flex-item [FFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 348.609375x17.46875 flex-item [BFC] children: inline
line 0 width: 348.609375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 40, rect: [8,8 348.609375x17.46875]
Box <div.inner> at (8,8) content-size 400x17 flex-container(row) flex-item [FFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 348.609375x17 flex-item [BFC] children: inline
line 0 width: 348.609375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 40, rect: [8,8 348.609375x17]
"The orange box should have a snug height"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
@ -13,6 +13,6 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x116]
PaintableBox (Box<BODY>.outer) [8,8 400x100]
PaintableBox (Box<DIV>.inner) [8,8 400x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,8 348.609375x17.46875]
PaintableBox (Box<DIV>.inner) [8,8 400x17]
PaintableWithLines (BlockContainer(anonymous)) [8,8 348.609375x17]
TextPaintable (TextNode<#text>)