RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 08:57:47 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/flex-shrink-1.txt
View file

@ -5,31 +5,31 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.box> at (10,10) content-size 62.671875x100 flex-item [BFC] children: inline
line 0 width: 18.9375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [10,10 18.9375x17.46875]
line 0 width: 18.9375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [10,10 18.9375x17]
"1 I"
line 1 width: 49.359375, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 4, length: 6, rect: [10,27 49.359375x17.46875]
line 1 width: 49.359375, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 4, length: 6, rect: [10,27 49.359375x17]
"shrink"
line 2 width: 24.875, height: 18.40625, bottom: 53.34375, baseline: 13.53125
frag 0 from TextNode start: 11, length: 3, rect: [10,44 24.875x17.46875]
line 2 width: 24.875, height: 17, bottom: 51, baseline: 13.296875
frag 0 from TextNode start: 11, length: 3, rect: [10,44 24.875x17]
"the"
line 3 width: 38.765625, height: 17.875, bottom: 70.28125, baseline: 13.53125
frag 0 from TextNode start: 15, length: 4, rect: [10,62 38.765625x17.46875]
line 3 width: 38.765625, height: 17, bottom: 68, baseline: 13.296875
frag 0 from TextNode start: 15, length: 4, rect: [10,61 38.765625x17]
"most"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.box> at (74.671875,10) content-size 81.328125x100 flex-item [BFC] children: inline
line 0 width: 78.765625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 10, rect: [74.671875,10 78.765625x17.46875]
line 0 width: 78.765625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 10, rect: [74.671875,10 78.765625x17]
"2 I shrink"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.box> at (158,10) content-size 100x100 flex-item [BFC] children: inline
line 0 width: 68, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [158,10 68x17.46875]
line 0 width: 68, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [158,10 68x17]
"3 I don't"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline