RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 18:27:36 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/LibWeb/Layout/expected/font-fractional-size.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x39.46875 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x23.46875 children: inline
line 0 width: 54.203125, height: 23.46875, bottom: 23.46875, baseline: 18.1875
frag 0 from TextNode start: 0, length: 1, rect: [8,8 12.4375x22.375]
BlockContainer <html> at (0,0) content-size 800x39 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x23 children: inline
line 0 width: 54.203125, height: 23, bottom: 23, baseline: 17.953125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 12.4375x22]
"x"
frag 1 from TextNode start: 0, length: 1, rect: [20,12 8x17.46875]
frag 1 from TextNode start: 0, length: 1, rect: [20,12 8x17]
" "
frag 2 from TextNode start: 0, length: 1, rect: [28,8 12.734375x22.921875]
frag 2 from TextNode start: 0, length: 1, rect: [28,8 12.734375x23]
"x"
frag 3 from TextNode start: 0, length: 1, rect: [41,12 8x17.46875]
frag 3 from TextNode start: 0, length: 1, rect: [41,12 8x17]
" "
frag 4 from TextNode start: 0, length: 1, rect: [49,8 13.03125x23.46875]
frag 4 from TextNode start: 0, length: 1, rect: [49,8 13.03125x23]
"x"
InlineNode <span.a>
TextNode <#text>
@ -23,8 +23,8 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x39.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x23.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x39]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x23]
InlinePaintable (InlineNode<SPAN>.a)
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)