RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:07:34 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Layout/expected/font-with-many-normal-values.txt
View file

@ -4,15 +4,15 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
line 0 width: 424, height: 200, bottom: 200, baseline: 159.96875
frag 0 from TextNode start: 0, length: 1, rect: [8,8 79.296875x200]
"1"
frag 1 from TextNode start: 0, length: 1, rect: [87,154 8x17.46875]
frag 1 from TextNode start: 0, length: 1, rect: [87,154 8x17]
" "
frag 2 from TextNode start: 0, length: 1, rect: [95,8 110.15625x200]
"2"
frag 3 from TextNode start: 0, length: 1, rect: [205,154 8x17.46875]
frag 3 from TextNode start: 0, length: 1, rect: [205,154 8x17]
" "
frag 4 from TextNode start: 0, length: 1, rect: [213,8 113.671875x200]
"3"
frag 5 from TextNode start: 0, length: 1, rect: [327,154 8x17.46875]
frag 5 from TextNode start: 0, length: 1, rect: [327,154 8x17]
" "
frag 6 from TextNode start: 0, length: 1, rect: [335,8 96.875x200]
"4"