RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:47:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/grid/container-min-height.txt
View file

@ -3,13 +3,13 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <body> at (10,10) content-size 780x202 children: not-inline
Box <div.container> at (11,11) content-size 778x200 [GFC] children: not-inline
BlockContainer <div> at (12,12) content-size 776x98 [BFC] children: inline
line 0 width: 311.21875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 35, rect: [12,12 311.21875x17.46875]
line 0 width: 311.21875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 35, rect: [12,12 311.21875x17]
"Making Commerce Better for Everyone"
TextNode <#text>
BlockContainer <div> at (12,112) content-size 776x98 [BFC] children: inline
line 0 width: 311.21875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 35, rect: [12,112 311.21875x17.46875]
line 0 width: 311.21875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 35, rect: [12,112 311.21875x17]
"Making Commerce Better for Everyone"
TextNode <#text>