1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:27:35 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -1,50 +1,50 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x27.46875 children: not-inline
Box <div.grid> at (8,8) content-size 784x27.46875 [GFC] children: not-inline
BlockContainer <div> at (8,8) content-size 784x27.46875 [BFC] children: not-inline
BlockContainer <div.left> at (8,8) content-size 6.34375x17.46875 floating [BFC] children: inline
line 0 width: 6.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 6.34375x17.46875]
BlockContainer <body> at (8,8) content-size 784x27 children: not-inline
Box <div.grid> at (8,8) content-size 784x27 [GFC] children: not-inline
BlockContainer <div> at (8,8) content-size 784x27 [BFC] children: not-inline
BlockContainer <div.left> at (8,8) content-size 6.34375x17 floating [BFC] children: inline
line 0 width: 6.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,8 6.34375x17]
"1"
TextNode <#text>
TableWrapper <(anonymous)> at (14.34375,8) content-size 156.796875x27.46875 floating [BFC] children: not-inline
Box <table.middle> at (15.34375,9) content-size 154.796875x25.46875 table-box [TFC] children: not-inline
Box <tbody> at (15.34375,9) content-size 148.796875x21.46875 table-row-group children: not-inline
Box <tr> at (17.34375,11) content-size 148.796875x21.46875 table-row children: not-inline
BlockContainer <td> at (19.34375,13) content-size 69.59375x17.46875 table-cell [BFC] children: inline
line 0 width: 8.8125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [19.34375,13 8.8125x17.46875]
TableWrapper <(anonymous)> at (14.34375,8) content-size 156.796875x27 floating [BFC] children: not-inline
Box <table.middle> at (15.34375,9) content-size 154.796875x25 table-box [TFC] children: not-inline
Box <tbody> at (15.34375,9) content-size 148.796875x21 table-row-group children: not-inline
Box <tr> at (17.34375,11) content-size 148.796875x21 table-row children: not-inline
BlockContainer <td> at (19.34375,13) content-size 69.59375x17 table-cell [BFC] children: inline
line 0 width: 8.8125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [19.34375,13 8.8125x17]
"2"
TextNode <#text>
BlockContainer <td> at (94.9375,13) content-size 71.203125x17.46875 table-cell [BFC] children: inline
line 0 width: 9.09375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [94.9375,13 9.09375x17.46875]
BlockContainer <td> at (94.9375,13) content-size 71.203125x17 table-cell [BFC] children: inline
line 0 width: 9.09375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [94.9375,13 9.09375x17]
"3"
TextNode <#text>
BlockContainer <div.right> at (171.140625,8) content-size 7.75x17.46875 floating [BFC] children: inline
line 0 width: 7.75, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [171.140625,8 7.75x17.46875]
BlockContainer <div.right> at (171.140625,8) content-size 7.75x17 floating [BFC] children: inline
line 0 width: 7.75, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [171.140625,8 7.75x17]
"4"
TextNode <#text>
BlockContainer <(anonymous)> at (8,35.46875) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,35) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x27.46875]
PaintableBox (Box<DIV>.grid) [8,8 784x27.46875]
PaintableWithLines (BlockContainer<DIV>) [8,8 784x27.46875]
PaintableWithLines (BlockContainer<DIV>.left) [8,8 6.34375x17.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x27]
PaintableBox (Box<DIV>.grid) [8,8 784x27]
PaintableWithLines (BlockContainer<DIV>) [8,8 784x27]
PaintableWithLines (BlockContainer<DIV>.left) [8,8 6.34375x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (TableWrapper(anonymous)) [14.34375,8 156.796875x27.46875]
PaintableBox (Box<TABLE>.middle) [14.34375,8 156.796875x27.46875]
PaintableBox (Box<TBODY>) [15.34375,9 148.796875x21.46875] overflow: [15.34375,9 152.796875x23.46875]
PaintableBox (Box<TR>) [17.34375,11 148.796875x21.46875] overflow: [17.34375,11 150.796875x21.46875]
PaintableWithLines (BlockContainer<TD>) [17.34375,11 73.59375x21.46875]
PaintableWithLines (TableWrapper(anonymous)) [14.34375,8 156.796875x27]
PaintableBox (Box<TABLE>.middle) [14.34375,8 156.796875x27]
PaintableBox (Box<TBODY>) [15.34375,9 148.796875x21] overflow: [15.34375,9 152.796875x23]
PaintableBox (Box<TR>) [17.34375,11 148.796875x21] overflow: [17.34375,11 150.796875x21]
PaintableWithLines (BlockContainer<TD>) [17.34375,11 73.59375x21]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [92.9375,11 75.203125x21.46875]
PaintableWithLines (BlockContainer<TD>) [92.9375,11 75.203125x21]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.right) [171.140625,8 7.75x17.46875]
PaintableWithLines (BlockContainer<DIV>.right) [171.140625,8 7.75x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,35.46875 784x0]
PaintableWithLines (BlockContainer(anonymous)) [8,35 784x0]