RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 09:27:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Tests/LibWeb/Layout/expected/grid/grid-item-fixed-paddings.txt
View file

@ -1,50 +1,50 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x355.5 children: not-inline
Box <div.grid-container> at (8,8) content-size 784x355.5 [GFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x356 children: not-inline
Box <div.grid-container> at (8,8) content-size 784x356 [GFC] children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (68,68) content-size 17.046875x32.75 [BFC] children: inline
line 0 width: 11.890625, height: 32.75, bottom: 32.75, baseline: 25.375
frag 0 from TextNode start: 0, length: 1, rect: [71,68 11.890625x32.75]
BlockContainer <div.grid-item> at (68,68) content-size 17.046875x33 [BFC] children: inline
line 0 width: 11.890625, height: 33, bottom: 33, baseline: 25.5
frag 0 from TextNode start: 0, length: 1, rect: [71,68 11.890625x33]
"1"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (255.046875,68) content-size 16.53125x32.75 [BFC] children: inline
line 0 width: 16.53125, height: 32.75, bottom: 32.75, baseline: 25.375
frag 0 from TextNode start: 0, length: 1, rect: [255.046875,68 16.53125x32.75]
BlockContainer <div.grid-item> at (255.046875,68) content-size 16.53125x33 [BFC] children: inline
line 0 width: 16.53125, height: 33, bottom: 33, baseline: 25.5
frag 0 from TextNode start: 0, length: 1, rect: [255.046875,68 16.53125x33]
"2"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (68,270.75) content-size 17.046875x32.75 [BFC] children: inline
line 0 width: 17.046875, height: 32.75, bottom: 32.75, baseline: 25.375
frag 0 from TextNode start: 0, length: 1, rect: [68,270.75 17.046875x32.75]
BlockContainer <div.grid-item> at (68,271) content-size 17.046875x33 [BFC] children: inline
line 0 width: 17.046875, height: 33, bottom: 33, baseline: 25.5
frag 0 from TextNode start: 0, length: 1, rect: [68,271 17.046875x33]
"3"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (255.046875,270.75) content-size 16.53125x32.75 [BFC] children: inline
line 0 width: 14.53125, height: 32.75, bottom: 32.75, baseline: 25.375
frag 0 from TextNode start: 0, length: 1, rect: [256.046875,270.75 14.53125x32.75]
BlockContainer <div.grid-item> at (255.046875,271) content-size 16.53125x33 [BFC] children: inline
line 0 width: 14.53125, height: 33, bottom: 33, baseline: 25.5
frag 0 from TextNode start: 0, length: 1, rect: [256.046875,271 14.53125x33]
"4"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,363.5) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,364) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x355.5]
PaintableBox (Box<DIV>.grid-container) [8,8 784x355.5]
PaintableWithLines (BlockContainer<DIV>.grid-item) [8,8 137.046875x152.75]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x356]
PaintableBox (Box<DIV>.grid-container) [8,8 784x356]
PaintableWithLines (BlockContainer<DIV>.grid-item) [8,8 137.046875x153]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.grid-item) [195.046875,8 136.53125x152.75]
PaintableWithLines (BlockContainer<DIV>.grid-item) [195.046875,8 136.53125x153]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.grid-item) [8,210.75 137.046875x152.75]
PaintableWithLines (BlockContainer<DIV>.grid-item) [8,211 137.046875x153]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.grid-item) [195.046875,210.75 136.53125x152.75]
PaintableWithLines (BlockContainer<DIV>.grid-item) [195.046875,211 136.53125x153]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,363.5 784x0]
PaintableWithLines (BlockContainer(anonymous)) [8,364 784x0]