mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 16:27:35 +00:00
LibWeb: Bring CSS line-height
closer to other engines
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
This commit is contained in:
parent
f0722671c3
commit
e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
|
@ -3,8 +3,8 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
BlockContainer <body> at (8,8) content-size 784x200 children: not-inline
|
||||
Box <div.grid-container> at (8,8) content-size 784x200 [GFC] children: not-inline
|
||||
BlockContainer <div.first> at (8,8) content-size 100x200 [BFC] children: inline
|
||||
line 0 width: 42.140625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [8,8 42.140625x17.46875]
|
||||
line 0 width: 42.140625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [8,8 42.140625x17]
|
||||
"First"
|
||||
TextNode <#text>
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue