RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:57:43 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Layout/expected/grid/grid-template-columns-with-min-css-function.txt
View file

@ -1,14 +1,14 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x54.9375 [BFC] children: not-inline
Box <body> at (10,10) content-size 780x36.9375 [GFC] children: not-inline
BlockContainer <h1> at (55.5,11) content-size 689x34.9375 [BFC] children: inline
line 0 width: 200.40625, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 13, rect: [55.5,11 200.40625x34.9375]
BlockContainer <html> at (1,1) content-size 798x55 [BFC] children: not-inline
Box <body> at (10,10) content-size 780x37 [GFC] children: not-inline
BlockContainer <h1> at (55.5,11) content-size 689x35 [BFC] children: inline
line 0 width: 200.40625, height: 35, bottom: 35, baseline: 27.09375
frag 0 from TextNode start: 0, length: 13, rect: [55.5,11 200.40625x35]
"hello friends"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x56.9375]
PaintableBox (Box<BODY>) [9,9 782x38.9375]
PaintableWithLines (BlockContainer<H1>) [54.5,10 691x36.9375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x57]
PaintableBox (Box<BODY>) [9,9 782x39]
PaintableWithLines (BlockContainer<H1>) [54.5,10 691x37]
TextPaintable (TextNode<#text>)