RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:37:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/grid/item-column-span-2.txt
View file

@ -1,30 +1,30 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x35.40625 children: not-inline
Box <div.container> at (8,8) content-size 784x35.40625 [GFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x34 children: not-inline
Box <div.container> at (8,8) content-size 784x34 [GFC] children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.item-left> at (8,8) content-size 100x35.40625 [BFC] children: not-inline
BlockContainer <div.item-left> at (8,8) content-size 100x34 [BFC] children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.item-right> at (108.03125,8) content-size 683.96875x35.40625 [BFC] children: inline
line 0 width: 625.953125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 77, rect: [108.03125,8 625.953125x17.46875]
BlockContainer <div.item-right> at (108.03125,8) content-size 683.96875x34 [BFC] children: inline
line 0 width: 625.953125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 77, rect: [108.03125,8 625.953125x17]
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut iaculis venenatis"
line 1 width: 304.0625, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 78, length: 39, rect: [108.03125,25 304.0625x17.46875]
line 1 width: 304.0625, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 78, length: 39, rect: [108.03125,25 304.0625x17]
"purus, eget blandit velit venenatis at."
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,43.40625) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,42) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x35.40625]
PaintableBox (Box<DIV>.container) [8,8 784x35.40625]
PaintableWithLines (BlockContainer<DIV>.item-left) [8,8 100x35.40625]
PaintableWithLines (BlockContainer<DIV>.item-right) [108.03125,8 683.96875x35.40625]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34]
PaintableBox (Box<DIV>.container) [8,8 784x34]
PaintableWithLines (BlockContainer<DIV>.item-left) [8,8 100x34]
PaintableWithLines (BlockContainer<DIV>.item-right) [108.03125,8 683.96875x34]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,43.40625 784x0]
PaintableWithLines (BlockContainer(anonymous)) [8,42 784x0]