RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 01:17:46 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Tests/LibWeb/Layout/expected/grid/item-with-box-sizing-border-box.txt
View file

@ -1,27 +1,27 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x41.46875 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x23.46875 children: not-inline
Box <div.grid> at (11,11) content-size 778x21.46875 [GFC] children: not-inline
BlockContainer <div.item> at (112,12) content-size 187x19.46875 [BFC] children: not-inline
BlockContainer <div> at (113,13) content-size 185x17.46875 children: inline
line 0 width: 29.8125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [113,13 29.8125x17.46875]
BlockContainer <html> at (1,1) content-size 798x41 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x23 children: not-inline
Box <div.grid> at (11,11) content-size 778x21 [GFC] children: not-inline
BlockContainer <div.item> at (112,12) content-size 187x19 [BFC] children: not-inline
BlockContainer <div> at (113,13) content-size 185x17 children: inline
line 0 width: 29.8125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [113,13 29.8125x17]
"One"
TextNode <#text>
BlockContainer <div.item> at (501,12) content-size 187x19.46875 [BFC] children: not-inline
BlockContainer <div> at (502,13) content-size 185x17.46875 children: inline
line 0 width: 33.875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [502,13 33.875x17.46875]
BlockContainer <div.item> at (501,12) content-size 187x19 [BFC] children: not-inline
BlockContainer <div> at (502,13) content-size 185x17 children: inline
line 0 width: 33.875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [502,13 33.875x17]
"Two"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x43.46875]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x25.46875]
PaintableBox (Box<DIV>.grid) [10,10 780x23.46875]
PaintableWithLines (BlockContainer<DIV>.item) [11,11 389x21.46875]
PaintableWithLines (BlockContainer<DIV>) [112,12 187x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x43]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x25]
PaintableBox (Box<DIV>.grid) [10,10 780x23]
PaintableWithLines (BlockContainer<DIV>.item) [11,11 389x21]
PaintableWithLines (BlockContainer<DIV>) [112,12 187x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.item) [400,11 389x21.46875]
PaintableWithLines (BlockContainer<DIV>) [501,12 187x19.46875]
PaintableWithLines (BlockContainer<DIV>.item) [400,11 389x21]
PaintableWithLines (BlockContainer<DIV>) [501,12 187x19]
TextPaintable (TextNode<#text>)