1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 09:07:44 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -1,99 +1,99 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x103.34375 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x87.34375 children: not-inline
Box <div.container> at (8,8) content-size 784x17.46875 [GFC] children: not-inline
BlockContainer <div> at (8,8) content-size 392x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [8,8 67.96875x17.46875]
BlockContainer <html> at (0,0) content-size 800x101 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x85 children: not-inline
Box <div.container> at (8,8) content-size 784x17 [GFC] children: not-inline
BlockContainer <div> at (8,8) content-size 392x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [8,8 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <div> at (400,8) content-size 392x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [400,8 67.96875x17.46875]
BlockContainer <div> at (400,8) content-size 392x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [400,8 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <(anonymous)> at (8,25.46875) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,25) content-size 784x0 children: inline
TextNode <#text>
Box <div.container> at (8,25.46875) content-size 784x17.46875 [GFC] children: not-inline
BlockContainer <div> at (8,25.46875) content-size 392x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [8,25.46875 67.96875x17.46875]
Box <div.container> at (8,25) content-size 784x17 [GFC] children: not-inline
BlockContainer <div> at (8,25) content-size 392x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [8,25 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <div> at (400,25.46875) content-size 392x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [400,25.46875 67.96875x17.46875]
BlockContainer <div> at (400,25) content-size 392x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [400,25 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <(anonymous)> at (8,42.9375) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,42) content-size 784x0 children: inline
TextNode <#text>
Box <div.container> at (8,42.9375) content-size 784x17.46875 [GFC] children: not-inline
BlockContainer <div> at (8,42.9375) content-size 67.96875x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [8,42.9375 67.96875x17.46875]
Box <div.container> at (8,42) content-size 784x17 [GFC] children: not-inline
BlockContainer <div> at (8,42) content-size 67.96875x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [8,42 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <div> at (75.96875,42.9375) content-size 67.96875x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [75.96875,42.9375 67.96875x17.46875]
BlockContainer <div> at (75.96875,42) content-size 67.96875x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [75.96875,42 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <(anonymous)> at (8,60.40625) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,59) content-size 784x0 children: inline
TextNode <#text>
Box <div.container> at (8,60.40625) content-size 784x17.46875 [GFC] children: not-inline
BlockContainer <div> at (332.03125,60.40625) content-size 67.96875x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [332.03125,60.40625 67.96875x17.46875]
Box <div.container> at (8,59) content-size 784x17 [GFC] children: not-inline
BlockContainer <div> at (332.03125,59) content-size 67.96875x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [332.03125,59 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <div> at (400,60.40625) content-size 67.96875x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [400,60.40625 67.96875x17.46875]
BlockContainer <div> at (400,59) content-size 67.96875x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [400,59 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <(anonymous)> at (8,77.875) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,76) content-size 784x0 children: inline
TextNode <#text>
Box <div.container> at (8,77.875) content-size 784x17.46875 [GFC] children: not-inline
BlockContainer <div> at (656.0625,77.875) content-size 67.96875x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [656.0625,77.875 67.96875x17.46875]
Box <div.container> at (8,76) content-size 784x17 [GFC] children: not-inline
BlockContainer <div> at (656.0625,76) content-size 67.96875x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [656.0625,76 67.96875x17]
"wikipedia"
TextNode <#text>
BlockContainer <div> at (724.03125,77.875) content-size 67.96875x17.46875 [BFC] children: inline
line 0 width: 67.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [724.03125,77.875 67.96875x17.46875]
BlockContainer <div> at (724.03125,76) content-size 67.96875x17 [BFC] children: inline
line 0 width: 67.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [724.03125,76 67.96875x17]
"wikipedia"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x103.34375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x87.34375]
PaintableBox (Box<DIV>.container) [8,8 784x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,8 392x17.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x101]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x85]
PaintableBox (Box<DIV>.container) [8,8 784x17]
PaintableWithLines (BlockContainer<DIV>) [8,8 392x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [400,8 392x17.46875]
PaintableWithLines (BlockContainer<DIV>) [400,8 392x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,25.46875 784x0]
PaintableBox (Box<DIV>.container) [8,25.46875 784x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,25.46875 392x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,25 784x0]
PaintableBox (Box<DIV>.container) [8,25 784x17]
PaintableWithLines (BlockContainer<DIV>) [8,25 392x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [400,25.46875 392x17.46875]
PaintableWithLines (BlockContainer<DIV>) [400,25 392x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,42.9375 784x0]
PaintableBox (Box<DIV>.container) [8,42.9375 784x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,42.9375 67.96875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,42 784x0]
PaintableBox (Box<DIV>.container) [8,42 784x17]
PaintableWithLines (BlockContainer<DIV>) [8,42 67.96875x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [75.96875,42.9375 67.96875x17.46875]
PaintableWithLines (BlockContainer<DIV>) [75.96875,42 67.96875x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,60.40625 784x0]
PaintableBox (Box<DIV>.container) [8,60.40625 784x17.46875]
PaintableWithLines (BlockContainer<DIV>) [332.03125,60.40625 67.96875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,59 784x0]
PaintableBox (Box<DIV>.container) [8,59 784x17]
PaintableWithLines (BlockContainer<DIV>) [332.03125,59 67.96875x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [400,60.40625 67.96875x17.46875]
PaintableWithLines (BlockContainer<DIV>) [400,59 67.96875x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,77.875 784x0]
PaintableBox (Box<DIV>.container) [8,77.875 784x17.46875]
PaintableWithLines (BlockContainer<DIV>) [656.0625,77.875 67.96875x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,76 784x0]
PaintableBox (Box<DIV>.container) [8,76 784x17]
PaintableWithLines (BlockContainer<DIV>) [656.0625,76 67.96875x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [724.03125,77.875 67.96875x17.46875]
PaintableWithLines (BlockContainer<DIV>) [724.03125,76 67.96875x17]
TextPaintable (TextNode<#text>)