RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 12:27:36 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

52
Tests/LibWeb/Layout/expected/grid/justify-items.txt
View file

@ -1,43 +1,43 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x82.40625 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x64.40625 children: not-inline
BlockContainer <html> at (1,1) content-size 798x81 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x63 children: not-inline
BlockContainer <(anonymous)> at (10,10) content-size 780x0 children: inline
TextNode <#text>
Box <div.grid.start> at (11,11) content-size 778x19.46875 [GFC] children: not-inline
BlockContainer <div> at (12,12) content-size 43.859375x17.46875 [BFC] children: inline
line 0 width: 43.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [12,12 43.859375x17.46875]
Box <div.grid.start> at (11,11) content-size 778x19 [GFC] children: not-inline
BlockContainer <div> at (12,12) content-size 43.859375x17 [BFC] children: inline
line 0 width: 43.859375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 5, rect: [12,12 43.859375x17]
"Start"
TextNode <#text>
BlockContainer <(anonymous)> at (10,31.46875) content-size 780x0 children: inline
BlockContainer <(anonymous)> at (10,31) content-size 780x0 children: inline
TextNode <#text>
Box <div.grid.center> at (11,32.46875) content-size 778x19.46875 [GFC] children: not-inline
BlockContainer <div> at (373.46875,33.46875) content-size 53.046875x17.46875 [BFC] children: inline
line 0 width: 53.046875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [373.46875,33.46875 53.046875x17.46875]
Box <div.grid.center> at (11,32) content-size 778x19 [GFC] children: not-inline
BlockContainer <div> at (373.46875,33) content-size 53.046875x17 [BFC] children: inline
line 0 width: 53.046875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [373.46875,33 53.046875x17]
"Center"
TextNode <#text>
BlockContainer <(anonymous)> at (10,52.9375) content-size 780x0 children: inline
BlockContainer <(anonymous)> at (10,52) content-size 780x0 children: inline
TextNode <#text>
Box <div.grid.end> at (11,53.9375) content-size 778x19.46875 [GFC] children: not-inline
BlockContainer <div> at (758.671875,54.9375) content-size 29.328125x17.46875 [BFC] children: inline
line 0 width: 29.328125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [758.671875,54.9375 29.328125x17.46875]
Box <div.grid.end> at (11,53) content-size 778x19 [GFC] children: not-inline
BlockContainer <div> at (758.671875,54) content-size 29.328125x17 [BFC] children: inline
line 0 width: 29.328125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [758.671875,54 29.328125x17]
"End"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x84.40625]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x66.40625]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x83]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x65]
PaintableWithLines (BlockContainer(anonymous)) [10,10 780x0]
PaintableBox (Box<DIV>.grid.start) [10,10 780x21.46875]
PaintableWithLines (BlockContainer<DIV>) [11,11 45.859375x19.46875]
PaintableBox (Box<DIV>.grid.start) [10,10 780x21]
PaintableWithLines (BlockContainer<DIV>) [11,11 45.859375x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [10,31.46875 780x0]
PaintableBox (Box<DIV>.grid.center) [10,31.46875 780x21.46875]
PaintableWithLines (BlockContainer<DIV>) [372.46875,32.46875 55.046875x19.46875]
PaintableWithLines (BlockContainer(anonymous)) [10,31 780x0]
PaintableBox (Box<DIV>.grid.center) [10,31 780x21]
PaintableWithLines (BlockContainer<DIV>) [372.46875,32 55.046875x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [10,52.9375 780x0]
PaintableBox (Box<DIV>.grid.end) [10,52.9375 780x21.46875]
PaintableWithLines (BlockContainer<DIV>) [757.671875,53.9375 31.328125x19.46875]
PaintableWithLines (BlockContainer(anonymous)) [10,52 780x0]
PaintableBox (Box<DIV>.grid.end) [10,52 780x21]
PaintableWithLines (BlockContainer<DIV>) [757.671875,53 31.328125x19]
TextPaintable (TextNode<#text>)