RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:57:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Tests/LibWeb/Layout/expected/grid/minmax-with-max-function-inside.txt
View file

@ -1,37 +1,37 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x34.9375 children: not-inline
Box <div.grid> at (8,8) content-size 784x34.9375 [GFC] children: not-inline
BlockContainer <div> at (8,8) content-size 261.328125x17.46875 [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 9.34375x17.46875]
BlockContainer <body> at (8,8) content-size 784x34 children: not-inline
Box <div.grid> at (8,8) content-size 784x34 [GFC] children: not-inline
BlockContainer <div> at (8,8) content-size 261.328125x17 [BFC] children: inline
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,8 9.34375x17]
"a"
TextNode <#text>
BlockContainer <div> at (269.328125,8) content-size 261.328125x17.46875 [BFC] children: inline
line 0 width: 9.46875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [269.328125,8 9.46875x17.46875]
BlockContainer <div> at (269.328125,8) content-size 261.328125x17 [BFC] children: inline
line 0 width: 9.46875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [269.328125,8 9.46875x17]
"b"
TextNode <#text>
BlockContainer <div> at (530.65625,8) content-size 261.328125x17.46875 [BFC] children: inline
line 0 width: 8.890625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [530.65625,8 8.890625x17.46875]
BlockContainer <div> at (530.65625,8) content-size 261.328125x17 [BFC] children: inline
line 0 width: 8.890625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [530.65625,8 8.890625x17]
"c"
TextNode <#text>
BlockContainer <div> at (8,25.46875) content-size 261.328125x17.46875 [BFC] children: inline
line 0 width: 7.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,25.46875 7.859375x17.46875]
BlockContainer <div> at (8,25) content-size 261.328125x17 [BFC] children: inline
line 0 width: 7.859375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,25 7.859375x17]
"d"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34.9375]
PaintableBox (Box<DIV>.grid) [8,8 784x34.9375]
PaintableWithLines (BlockContainer<DIV>) [8,8 261.328125x17.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34]
PaintableBox (Box<DIV>.grid) [8,8 784x34]
PaintableWithLines (BlockContainer<DIV>) [8,8 261.328125x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [269.328125,8 261.328125x17.46875]
PaintableWithLines (BlockContainer<DIV>) [269.328125,8 261.328125x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [530.65625,8 261.328125x17.46875]
PaintableWithLines (BlockContainer<DIV>) [530.65625,8 261.328125x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [8,25.46875 261.328125x17.46875]
PaintableWithLines (BlockContainer<DIV>) [8,25 261.328125x17]
TextPaintable (TextNode<#text>)