1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:57:35 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -1,95 +1,95 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x69.875 children: not-inline
Box <div.grid> at (8,8) content-size 784x69.875 [GFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x68 children: not-inline
Box <div.grid> at (8,8) content-size 784x68 [GFC] children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.a> at (8,8) content-size 196x17.46875 [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 9.34375x17.46875]
BlockContainer <div.a> at (8,8) content-size 196x17 [BFC] children: inline
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,8 9.34375x17]
"a"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.c> at (204,8) content-size 196x17.46875 [BFC] children: inline
line 0 width: 8.890625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [204,8 8.890625x17.46875]
BlockContainer <div.c> at (204,8) content-size 196x17 [BFC] children: inline
line 0 width: 8.890625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [204,8 8.890625x17]
"c"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.b> at (400,8) content-size 196x17.46875 [BFC] children: inline
line 0 width: 9.46875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [400,8 9.46875x17.46875]
BlockContainer <div.b> at (400,8) content-size 196x17 [BFC] children: inline
line 0 width: 9.46875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [400,8 9.46875x17]
"b"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.b> at (400,25.46875) content-size 196x17.46875 [BFC] children: inline
line 0 width: 9.46875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [400,25.46875 9.46875x17.46875]
BlockContainer <div.b> at (400,25) content-size 196x17 [BFC] children: inline
line 0 width: 9.46875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [400,25 9.46875x17]
"b"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.d> at (596,25.46875) content-size 196x17.46875 [BFC] children: inline
line 0 width: 7.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [596,25.46875 7.859375x17.46875]
BlockContainer <div.d> at (596,25) content-size 196x17 [BFC] children: inline
line 0 width: 7.859375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [596,25 7.859375x17]
"d"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.c> at (204,42.9375) content-size 196x17.46875 [BFC] children: inline
line 0 width: 8.890625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [204,42.9375 8.890625x17.46875]
BlockContainer <div.c> at (204,42) content-size 196x17 [BFC] children: inline
line 0 width: 8.890625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [204,42 8.890625x17]
"c"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.d> at (596,42.9375) content-size 196x17.46875 [BFC] children: inline
line 0 width: 7.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [596,42.9375 7.859375x17.46875]
BlockContainer <div.d> at (596,42) content-size 196x17 [BFC] children: inline
line 0 width: 7.859375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [596,42 7.859375x17]
"d"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.e> at (8,60.40625) content-size 196x17.46875 [BFC] children: inline
line 0 width: 8.71875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,60.40625 8.71875x17.46875]
BlockContainer <div.e> at (8,59) content-size 196x17 [BFC] children: inline
line 0 width: 8.71875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,59 8.71875x17]
"e"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.f> at (204,60.40625) content-size 196x17.46875 [BFC] children: inline
line 0 width: 6.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [204,60.40625 6.4375x17.46875]
BlockContainer <div.f> at (204,59) content-size 196x17 [BFC] children: inline
line 0 width: 6.4375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [204,59 6.4375x17]
"f"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,77.875) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,76) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x69.875]
PaintableBox (Box<DIV>.grid) [8,8 784x69.875]
PaintableWithLines (BlockContainer<DIV>.a) [8,8 196x17.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x68]
PaintableBox (Box<DIV>.grid) [8,8 784x68]
PaintableWithLines (BlockContainer<DIV>.a) [8,8 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.c) [204,8 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.c) [204,8 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.b) [400,8 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.b) [400,8 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.b) [400,25.46875 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.b) [400,25 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.d) [596,25.46875 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.d) [596,25 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.c) [204,42.9375 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.c) [204,42 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.d) [596,42.9375 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.d) [596,42 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.e) [8,60.40625 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.e) [8,59 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.f) [204,60.40625 196x17.46875]
PaintableWithLines (BlockContainer<DIV>.f) [204,59 196x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,77.875 784x0]
PaintableWithLines (BlockContainer(anonymous)) [8,76 784x0]