RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:17:34 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Tests/LibWeb/Layout/expected/grid/place-items-center-nested-grids.txt
View file

@ -1,28 +1,28 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x104.21875 [BFC] children: not-inline
Box <body> at (8,8) content-size 784x88.21875 [GFC] children: not-inline
Box <div> at (8,8) content-size 784x88.21875 [GFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 65.328125x88.21875 [BFC] children: inline
line 0 width: 50.5625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [8,8 50.5625x17.46875]
BlockContainer <html> at (0,0) content-size 800x101 [BFC] children: not-inline
Box <body> at (8,8) content-size 784x85 [GFC] children: not-inline
Box <div> at (8,8) content-size 784x85 [GFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 65.328125x85 [BFC] children: inline
line 0 width: 50.5625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [8,8 50.5625x17]
"Making"
line 1 width: 80.234375, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 7, length: 8, rect: [8,25 80.234375x17.46875]
line 1 width: 80.234375, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 7, length: 8, rect: [8,25 80.234375x17]
"Commerce"
line 2 width: 49.328125, height: 18.40625, bottom: 53.34375, baseline: 13.53125
frag 0 from TextNode start: 16, length: 6, rect: [8,42 49.328125x17.46875]
line 2 width: 49.328125, height: 17, bottom: 51, baseline: 13.296875
frag 0 from TextNode start: 16, length: 6, rect: [8,42 49.328125x17]
"Better"
line 3 width: 25.625, height: 17.875, bottom: 70.28125, baseline: 13.53125
frag 0 from TextNode start: 23, length: 3, rect: [8,60 25.625x17.46875]
line 3 width: 25.625, height: 17, bottom: 68, baseline: 13.296875
frag 0 from TextNode start: 23, length: 3, rect: [8,59 25.625x17]
"for"
line 4 width: 73.46875, height: 18.34375, bottom: 88.21875, baseline: 13.53125
frag 0 from TextNode start: 27, length: 8, rect: [8,77 73.46875x17.46875]
line 4 width: 73.46875, height: 17, bottom: 85, baseline: 13.296875
frag 0 from TextNode start: 27, length: 8, rect: [8,76 73.46875x17]
"Everyone"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x104.21875]
PaintableBox (Box<BODY>) [8,8 784x88.21875]
PaintableBox (Box<DIV>) [8,8 784x88.21875]
PaintableWithLines (BlockContainer(anonymous)) [8,8 65.328125x88.21875] overflow: [8,8 80.234375x88.21875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x101]
PaintableBox (Box<BODY>) [8,8 784x85]
PaintableBox (Box<DIV>) [8,8 784x85]
PaintableWithLines (BlockContainer(anonymous)) [8,8 65.328125x85] overflow: [8,8 80.234375x85]
TextPaintable (TextNode<#text>)