RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 22:17:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/grid/vertical-margins-auto.txt
View file

@ -2,9 +2,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x520 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x502 children: not-inline
Box <div.container> at (11,11) content-size 500x500 [GFC] children: not-inline
BlockContainer <div.item> at (244.828125,252.265625) content-size 32.34375x17.46875 [BFC] children: inline
line 0 width: 32.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [244.828125,252.265625 32.34375x17.46875]
BlockContainer <div.item> at (244.828125,252.5) content-size 32.34375x17 [BFC] children: inline
line 0 width: 32.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 4, rect: [244.828125,252.5 32.34375x17]
"item"
TextNode <#text>
@ -12,5 +12,5 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x522]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x504]
PaintableBox (Box<DIV>.container) [10,10 502x502]
PaintableWithLines (BlockContainer<DIV>.item) [243.828125,251.265625 34.34375x19.46875]
PaintableWithLines (BlockContainer<DIV>.item) [243.828125,251.5 34.34375x19]
TextPaintable (TextNode<#text>)