RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 12:27:36 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Tests/LibWeb/Layout/expected/height-min-max-fit-content.txt
View file

@ -1,12 +1,12 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x139.46875 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x123.46875 children: inline
line 0 width: 376, height: 123.46875, bottom: 123.46875, baseline: 120
BlockContainer <html> at (0,0) content-size 800x139 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x123 children: inline
line 0 width: 376, height: 123, bottom: 123, baseline: 120
frag 0 from ImageBox start: 0, length: 0, rect: [8,8 120x120]
frag 1 from TextNode start: 0, length: 1, rect: [128,114 8x17.46875]
frag 1 from TextNode start: 0, length: 1, rect: [128,114 8x17]
" "
frag 2 from ImageBox start: 0, length: 0, rect: [136,8 120x120]
frag 3 from TextNode start: 0, length: 1, rect: [256,114 8x17.46875]
frag 3 from TextNode start: 0, length: 1, rect: [256,114 8x17]
" "
frag 4 from ImageBox start: 0, length: 0, rect: [264,8 120x120]
ImageBox <img.min> at (8,8) content-size 120x120 children: not-inline
@ -17,8 +17,8 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x139.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x123.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x139]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x123]
ImagePaintable (ImageBox<IMG>.min) [8,8 120x120]
TextPaintable (TextNode<#text>)
ImagePaintable (ImageBox<IMG>.max) [136,8 120x120]