RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 12:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Tests/LibWeb/Layout/expected/inline-block-treat-100pct-width-as-auto.txt
View file

@ -1,22 +1,22 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x82.46875 [BFC] children: not-inline
BlockContainer <html> at (1,1) content-size 798x82 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x0 children: not-inline
BlockContainer <div.outer> at (11,11) content-size 102.484375x71.46875 floating [BFC] children: not-inline
BlockContainer <(anonymous)> at (11,11) content-size 102.484375x19.46875 children: inline
line 0 width: 104.484375, height: 19.46875, bottom: 19.46875, baseline: 14.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [12,12 102.484375x17.46875]
BlockContainer <div.first> at (12,12) content-size 102.484375x17.46875 inline-block [BFC] children: inline
line 0 width: 100.484375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 11, rect: [12,12 100.484375x17.46875]
BlockContainer <div.outer> at (11,11) content-size 102.484375x71 floating [BFC] children: not-inline
BlockContainer <(anonymous)> at (11,11) content-size 102.484375x19 children: inline
line 0 width: 104.484375, height: 19, bottom: 19, baseline: 14.296875
frag 0 from BlockContainer start: 0, length: 0, rect: [12,12 102.484375x17]
BlockContainer <div.first> at (12,12) content-size 102.484375x17 inline-block [BFC] children: inline
line 0 width: 100.484375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 11, rect: [12,12 100.484375x17]
"programming"
TextNode <#text>
BlockContainer <div.second> at (12,31.46875) content-size 50x50 children: not-inline
BlockContainer <div.second> at (12,31) content-size 50x50 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x84.46875]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x2] overflow: [10,10 104.484375x73.46875]
PaintableWithLines (BlockContainer<DIV>.outer) [10,10 104.484375x73.46875] overflow: [11,11 103.484375x71.46875]
PaintableWithLines (BlockContainer(anonymous)) [11,11 102.484375x19.46875] overflow: [11,11 103.484375x19.46875]
PaintableWithLines (BlockContainer<DIV>.first) [11,11 104.484375x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x84]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x2] overflow: [10,10 104.484375x73]
PaintableWithLines (BlockContainer<DIV>.outer) [10,10 104.484375x73] overflow: [11,11 103.484375x71]
PaintableWithLines (BlockContainer(anonymous)) [11,11 102.484375x19] overflow: [11,11 103.484375x19]
PaintableWithLines (BlockContainer<DIV>.first) [11,11 104.484375x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.second) [11,30.46875 52x52]
PaintableWithLines (BlockContainer<DIV>.second) [11,30 52x52]