RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 11:57:36 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Tests/LibWeb/Layout/expected/inline-size.txt
View file

@ -1,30 +1,30 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x570.84375 [BFC] children: not-inline
BlockContainer <body> at (8,70) content-size 784x492.84375 children: not-inline
BlockContainer <html> at (0,0) content-size 800x570 [BFC] children: not-inline
BlockContainer <body> at (8,70) content-size 784x492 children: not-inline
BlockContainer <p.min-inline-test> at (8,70) content-size 784x200 children: inline
line 0 width: 85.859375, height: 76.421875, bottom: 76.421875, baseline: 59.1875
frag 0 from TextNode start: 0, length: 2, rect: [8,70 85.859375x76.421875]
line 0 width: 85.859375, height: 76, bottom: 76, baseline: 58.984375
frag 0 from TextNode start: 0, length: 2, rect: [8,70 85.859375x76]
"KK"
TextNode <#text>
BlockContainer <(anonymous)> at (8,340) content-size 784x76.421875 children: inline
line 0 width: 0, height: 76.421875, bottom: 76.421875, baseline: 59.1875
BlockContainer <(anonymous)> at (8,340) content-size 784x76 children: inline
line 0 width: 0, height: 76, bottom: 76, baseline: 58.984375
TextNode <#text>
BreakNode <br>
TextNode <#text>
BlockContainer <p.max-inline-test> at (8,486.421875) content-size 100x76.421875 children: inline
line 0 width: 85.859375, height: 76.421875, bottom: 76.421875, baseline: 59.1875
frag 0 from TextNode start: 0, length: 2, rect: [8,486.421875 85.859375x76.421875]
BlockContainer <p.max-inline-test> at (8,486) content-size 100x76 children: inline
line 0 width: 85.859375, height: 76, bottom: 76, baseline: 58.984375
frag 0 from TextNode start: 0, length: 2, rect: [8,486 85.859375x76]
"KK"
TextNode <#text>
BlockContainer <(anonymous)> at (8,632.84375) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,632) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 800x632.84375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x570.84375] overflow: [0,0 800x632.84375]
PaintableWithLines (BlockContainer<BODY>) [8,70 784x492.84375] overflow: [8,70 784x562.84375]
ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 800x632]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x570] overflow: [0,0 800x632]
PaintableWithLines (BlockContainer<BODY>) [8,70 784x492] overflow: [8,70 784x562]
PaintableWithLines (BlockContainer<P>.min-inline-test) [8,70 784x200]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,340 784x76.421875]
PaintableWithLines (BlockContainer<P>.max-inline-test) [8,486.421875 100x76.421875]
PaintableWithLines (BlockContainer(anonymous)) [8,340 784x76]
PaintableWithLines (BlockContainer<P>.max-inline-test) [8,486 100x76]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,632.84375 784x0]
PaintableWithLines (BlockContainer(anonymous)) [8,632 784x0]