RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:17:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/input-element-with-display-inline.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x45.84375 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x27.84375 children: inline
line 0 width: 202, height: 27.84375, bottom: 27.84375, baseline: 27.84375
frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 200x25.84375]
BlockContainer <input> at (11,11) content-size 200x25.84375 inline-block [BFC] children: not-inline
Box <div> at (13,12) content-size 196x23.84375 flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (14,13) content-size 194x21.84375 flex-item [BFC] children: inline
BlockContainer <html> at (1,1) content-size 798x46 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x28 children: inline
line 0 width: 202, height: 28, bottom: 28, baseline: 28
frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 200x26]
BlockContainer <input> at (11,11) content-size 200x26 inline-block [BFC] children: not-inline
Box <div> at (13,12) content-size 196x24 flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (14,13) content-size 194x22 flex-item [BFC] children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x47.84375]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x29.84375]
PaintableWithLines (BlockContainer<INPUT>) [10,10 202x27.84375]
PaintableBox (Box<DIV>) [11,11 200x25.84375]
PaintableWithLines (BlockContainer<DIV>) [13,12 196x23.84375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x48]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x30]
PaintableWithLines (BlockContainer<INPUT>) [10,10 202x28]
PaintableBox (Box<DIV>) [11,11 200x26]
PaintableWithLines (BlockContainer<DIV>) [13,12 196x24]