RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 07:27:44 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Layout/expected/nowrap-and-no-line-break-opportunity.txt
View file

@ -1,13 +1,13 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x19.46875 children: not-inline
BlockContainer <div.fixed_width> at (9,9) content-size 50x17.46875 children: inline
line 0 width: 79.40625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [9,9 33.921875x17.46875]
BlockContainer <body> at (8,8) content-size 784x19 children: not-inline
BlockContainer <div.fixed_width> at (9,9) content-size 50x17 children: inline
line 0 width: 79.40625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [9,9 33.921875x17]
"ABC"
frag 1 from TextNode start: 0, length: 1, rect: [43,9 11.5625x17.46875]
frag 1 from TextNode start: 0, length: 1, rect: [43,9 11.5625x17]
"X"
frag 2 from TextNode start: 0, length: 3, rect: [54,9 33.921875x17.46875]
frag 2 from TextNode start: 0, length: 3, rect: [54,9 33.921875x17]
"ABC"
TextNode <#text>
InlineNode <span.nowrap>
@ -20,8 +20,8 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x19.46875]
PaintableWithLines (BlockContainer<DIV>.fixed_width) [8,8 52x19.46875] overflow: [9,9 78.921875x17.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x19]
PaintableWithLines (BlockContainer<DIV>.fixed_width) [8,8 52x19] overflow: [9,9 78.921875x17]
InlinePaintable (InlineNode<SPAN>.nowrap)
TextPaintable (TextNode<#text>)
InlinePaintable (InlineNode<SPAN>)