RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:37:46 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Tests/LibWeb/Layout/expected/resolve-height-of-containing-block.txt
View file

@ -13,12 +13,12 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <(anonymous)> at (8,16) content-size 1280x0 children: inline
TextNode <#text>
TextNode <#text>
BlockContainer <p> at (8,16) content-size 1280x17.46875 children: inline
line 0 width: 37.21875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [8,16 37.21875x17.46875]
BlockContainer <p> at (8,16) content-size 1280x17 children: inline
line 0 width: 37.21875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 4, rect: [8,16 37.21875x17]
"Test"
TextNode <#text>
BlockContainer <(anonymous)> at (8,49.46875) content-size 1280x0 children: inline
BlockContainer <(anonymous)> at (8,49) content-size 1280x0 children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,416) content-size 1280x0 children: inline
TextNode <#text>
@ -35,8 +35,8 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 1288x824]
PaintableWithLines (BlockContainer<DIV>) [8,16 1280x400]
ImagePaintable (ImageBox<IMG>) [488,16 800x400]
PaintableWithLines (BlockContainer(anonymous)) [8,16 1280x0]
PaintableWithLines (BlockContainer<P>) [8,16 1280x17.46875]
PaintableWithLines (BlockContainer<P>) [8,16 1280x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,49.46875 1280x0]
PaintableWithLines (BlockContainer(anonymous)) [8,49 1280x0]
PaintableWithLines (BlockContainer(anonymous)) [8,416 1280x0]
PaintableWithLines (BlockContainer(anonymous)) [8,816 784x0]