RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:07:34 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Tests/LibWeb/Layout/expected/svg-transforms-and-viewboxes.txt
View file

@ -1,20 +1,20 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x700 [BFC] children: not-inline
BlockContainer <body> at (50,50) content-size 700x600 children: inline
line 0 width: 616, height: 203.46875, bottom: 203.46875, baseline: 200
line 0 width: 616, height: 203, bottom: 203, baseline: 200
frag 0 from SVGSVGBox start: 0, length: 0, rect: [50,150 200x100]
frag 1 from TextNode start: 0, length: 1, rect: [250,236 8x17.46875]
frag 1 from TextNode start: 0, length: 1, rect: [250,236 8x17]
" "
frag 2 from SVGSVGBox start: 0, length: 0, rect: [258,50 200x200]
frag 3 from TextNode start: 0, length: 1, rect: [458,236 8x17.46875]
frag 3 from TextNode start: 0, length: 1, rect: [458,236 8x17]
" "
frag 4 from SVGSVGBox start: 0, length: 0, rect: [466,50 200x200]
line 1 width: 616, height: 203.46875, bottom: 403.46875, baseline: 200
line 1 width: 616, height: 203, bottom: 403, baseline: 200
frag 0 from SVGSVGBox start: 0, length: 0, rect: [50,250 200x200]
frag 1 from TextNode start: 0, length: 1, rect: [250,436 8x17.46875]
frag 1 from TextNode start: 0, length: 1, rect: [250,436 8x17]
" "
frag 2 from SVGSVGBox start: 0, length: 0, rect: [258,250 200x200]
frag 3 from TextNode start: 0, length: 1, rect: [458,436 8x17.46875]
frag 3 from TextNode start: 0, length: 1, rect: [458,436 8x17]
" "
frag 4 from SVGSVGBox start: 0, length: 0, rect: [466,250 200x200]
line 2 width: 200, height: 200, bottom: 600, baseline: 200