RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:47:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/table/border-attribute-overridden-by-css.txt
View file

@ -1,22 +1,22 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x45.46875 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 42.265625x45.46875 [BFC] children: not-inline
Box <table> at (18,18) content-size 22.265625x25.46875 table-box [TFC] children: not-inline
Box <tbody> at (18,18) content-size 18.265625x21.46875 table-row-group children: not-inline
Box <tr> at (20,20) content-size 18.265625x21.46875 table-row children: not-inline
BlockContainer <td> at (22,22) content-size 14.265625x17.46875 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [22,22 14.265625x17.46875]
BlockContainer <body> at (8,8) content-size 784x45 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 42.265625x45 [BFC] children: not-inline
Box <table> at (18,18) content-size 22.265625x25 table-box [TFC] children: not-inline
Box <tbody> at (18,18) content-size 18.265625x21 table-row-group children: not-inline
Box <tr> at (20,20) content-size 18.265625x21 table-row children: not-inline
BlockContainer <td> at (22,22) content-size 14.265625x17 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [22,22 14.265625x17]
"A"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x45.46875]
PaintableWithLines (TableWrapper(anonymous)) [8,8 42.265625x45.46875]
PaintableBox (Box<TABLE>) [8,8 42.265625x45.46875]
PaintableBox (Box<TBODY>) [18,18 18.265625x21.46875] overflow: [18,18 20.265625x23.46875]
PaintableBox (Box<TR>) [20,20 18.265625x21.46875]
PaintableWithLines (BlockContainer<TD>) [20,20 18.265625x21.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x45]
PaintableWithLines (TableWrapper(anonymous)) [8,8 42.265625x45]
PaintableBox (Box<TABLE>) [8,8 42.265625x45]
PaintableBox (Box<TBODY>) [18,18 18.265625x21] overflow: [18,18 20.265625x23]
PaintableBox (Box<TR>) [20,20 18.265625x21]
PaintableWithLines (BlockContainer<TD>) [20,20 18.265625x21]
TextPaintable (TextNode<#text>)