1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 06:27:45 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -1,63 +1,63 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x177.875 [BFC] children: not-inline
BlockContainer <html> at (0,0) content-size 800x176 [BFC] children: not-inline
BlockContainer <(anonymous)> at (0,0) content-size 800x0 children: inline
TextNode <#text>
BlockContainer <body> at (8,8) content-size 784x161.875 children: not-inline
BlockContainer <body> at (8,8) content-size 784x160 children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 784x0 children: inline
TextNode <#text>
TableWrapper <(anonymous)> at (8,8) content-size 60.265625x161.875 [BFC] children: not-inline
Box <table> at (8,8) content-size 60.265625x161.875 table-box [TFC] children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 60.265625x160 [BFC] children: not-inline
Box <table> at (8,8) content-size 60.265625x160 table-box [TFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <colgroup> (not painted) table-column-group children: not-inline
BlockContainer <col> (not painted) children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tbody> at (8,8) content-size 60.265625x161.875 table-row-group children: not-inline
Box <tbody> at (8,8) content-size 60.265625x160 table-row-group children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (8,8) content-size 60.265625x41.46875 table-row children: not-inline
Box <tr> at (8,8) content-size 60.265625x41 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (31,21) content-size 14.265625x17.46875 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [31,21 14.265625x17.46875]
BlockContainer <td> at (31,21) content-size 14.265625x17 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [31,21 14.265625x17]
"A"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (8,49.46875) content-size 60.265625x39.46875 table-row children: not-inline
Box <tr> at (8,49) content-size 60.265625x39 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (31,60.46875) content-size 14.265625x17.46875 table-cell [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [31,60.46875 9.34375x17.46875]
BlockContainer <td> at (31,60) content-size 14.265625x17 table-cell [BFC] children: inline
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [31,60 9.34375x17]
"B"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (8,88.9375) content-size 60.265625x39.46875 table-row children: not-inline
Box <tr> at (8,88) content-size 60.265625x39 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (31,99.9375) content-size 14.265625x17.46875 table-cell [BFC] children: inline
line 0 width: 10.3125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [31,99.9375 10.3125x17.46875]
BlockContainer <td> at (31,99) content-size 14.265625x17 table-cell [BFC] children: inline
line 0 width: 10.3125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [31,99 10.3125x17]
"C"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (8,128.40625) content-size 60.265625x41.46875 table-row children: not-inline
Box <tr> at (8,127) content-size 60.265625x41 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (31,139.40625) content-size 14.265625x17.46875 table-cell [BFC] children: inline
line 0 width: 11.140625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [31,139.40625 11.140625x17.46875]
BlockContainer <td> at (31,138) content-size 14.265625x17 table-cell [BFC] children: inline
line 0 width: 11.140625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [31,138 11.140625x17]
"D"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -66,27 +66,27 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,169.875) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,168) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x177.875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x176]
PaintableWithLines (BlockContainer(anonymous)) [0,0 800x0]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x161.875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x160]
PaintableWithLines (BlockContainer(anonymous)) [8,8 784x0]
PaintableWithLines (TableWrapper(anonymous)) [8,8 60.265625x161.875]
PaintableBox (Box<TABLE>) [8,8 60.265625x161.875]
PaintableBox (Box<TBODY>) [8,8 60.265625x161.875]
PaintableBox (Box<TR>) [8,8 60.265625x41.46875]
PaintableWithLines (BlockContainer<TD>) [8,8 60.265625x41.46875]
PaintableWithLines (TableWrapper(anonymous)) [8,8 60.265625x160]
PaintableBox (Box<TABLE>) [8,8 60.265625x160]
PaintableBox (Box<TBODY>) [8,8 60.265625x160]
PaintableBox (Box<TR>) [8,8 60.265625x41]
PaintableWithLines (BlockContainer<TD>) [8,8 60.265625x41]
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [8,49.46875 60.265625x39.46875]
PaintableWithLines (BlockContainer<TD>) [8,49.46875 60.265625x39.46875]
PaintableBox (Box<TR>) [8,49 60.265625x39]
PaintableWithLines (BlockContainer<TD>) [8,49 60.265625x39]
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [8,88.9375 60.265625x39.46875]
PaintableWithLines (BlockContainer<TD>) [8,88.9375 60.265625x39.46875]
PaintableBox (Box<TR>) [8,88 60.265625x39]
PaintableWithLines (BlockContainer<TD>) [8,88 60.265625x39]
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [8,128.40625 60.265625x41.46875]
PaintableWithLines (BlockContainer<TD>) [8,128.40625 60.265625x41.46875]
PaintableBox (Box<TR>) [8,127 60.265625x41]
PaintableWithLines (BlockContainer<TD>) [8,127 60.265625x41]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,169.875 784x0]
PaintableWithLines (BlockContainer(anonymous)) [8,168 784x0]