mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 03:57:35 +00:00
LibWeb: Bring CSS line-height closer to other engines
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling
parent
f0722671c3
commit
e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
|
|
@ -1,64 +1,64 @@
|
|||
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
||||
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x130.40625 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 114.8125x130.40625 [BFC] children: not-inline
|
||||
Box <table> at (8,8) content-size 114.8125x130.40625 table-box [TFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x129 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 114.8125x129 [BFC] children: not-inline
|
||||
Box <table> at (8,8) content-size 114.8125x129 table-box [TFC] children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tbody> at (8,8) content-size 114.8125x130.40625 table-row-group children: not-inline
|
||||
Box <tbody> at (8,8) content-size 114.8125x129 table-row-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr.td-thick-border> at (8,8) content-size 114.8125x43.46875 table-row children: not-inline
|
||||
Box <tr.td-thick-border> at (8,8) content-size 114.8125x43 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (31,21) content-size 14.265625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,21 14.265625x17.46875]
|
||||
BlockContainer <td> at (31,21) content-size 14.265625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,21 14.265625x17]
|
||||
"A"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (87.265625,21) content-size 12.546875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,21 9.34375x17.46875]
|
||||
BlockContainer <td> at (87.265625,21) content-size 12.546875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,21 9.34375x17]
|
||||
"B"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (8,51.46875) content-size 114.8125x43.46875 table-row children: not-inline
|
||||
Box <tr> at (8,51) content-size 114.8125x43 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (29,64.46875) content-size 16.265625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 10.3125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [29,64.46875 10.3125x17.46875]
|
||||
BlockContainer <td> at (29,64) content-size 16.265625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 10.3125, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [29,64 10.3125x17]
|
||||
"C"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (87.265625,64.46875) content-size 14.546875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 11.140625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,64.46875 11.140625x17.46875]
|
||||
BlockContainer <td> at (87.265625,64) content-size 14.546875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 11.140625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,64 11.140625x17]
|
||||
"D"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr.td-thick-border> at (8,94.9375) content-size 114.8125x43.46875 table-row children: not-inline
|
||||
Box <tr.td-thick-border> at (8,94) content-size 114.8125x43 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (31,107.9375) content-size 14.265625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 11.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,107.9375 11.859375x17.46875]
|
||||
BlockContainer <td> at (31,107) content-size 14.265625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 11.859375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,107 11.859375x17]
|
||||
"E"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (87.265625,107.9375) content-size 12.546875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 12.546875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,107.9375 12.546875x17.46875]
|
||||
BlockContainer <td> at (87.265625,107) content-size 12.546875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 12.546875, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,107 12.546875x17]
|
||||
"F"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
|
|
@ -70,22 +70,22 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
|
||||
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x130.40625]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 114.8125x130.40625]
|
||||
PaintableBox (Box<TABLE>) [8,8 114.8125x130.40625]
|
||||
PaintableBox (Box<TBODY>) [8,8 114.8125x130.40625]
|
||||
PaintableBox (Box<TR>.td-thick-border) [8,8 114.8125x43.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,8 58.265625x43.46875]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x129]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 114.8125x129]
|
||||
PaintableBox (Box<TABLE>) [8,8 114.8125x129]
|
||||
PaintableBox (Box<TBODY>) [8,8 114.8125x129]
|
||||
PaintableBox (Box<TR>.td-thick-border) [8,8 114.8125x43]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,8 58.265625x43]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,8 56.546875x43.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,8 56.546875x43]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TR>) [8,51.46875 114.8125x43.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,51.46875 58.265625x43.46875]
|
||||
PaintableBox (Box<TR>) [8,51 114.8125x43]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,51 58.265625x43]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,51.46875 56.546875x43.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,51 56.546875x43]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TR>.td-thick-border) [8,94.9375 114.8125x43.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,94.9375 58.265625x43.46875]
|
||||
PaintableBox (Box<TR>.td-thick-border) [8,94 114.8125x43]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,94 58.265625x43]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,94.9375 56.546875x43.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,94 56.546875x43]
|
||||
TextPaintable (TextNode<#text>)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue