mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 06:57:45 +00:00
LibWeb: Bring CSS line-height closer to other engines
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling
parent
f0722671c3
commit
e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
|
|
@ -1,65 +1,65 @@
|
|||
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
||||
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x124.40625 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 113.40625x124.40625 [BFC] children: not-inline
|
||||
Box <table> at (8,8) content-size 113.40625x124.40625 table-box [TFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x123 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 113.40625x123 [BFC] children: not-inline
|
||||
Box <table> at (8,8) content-size 113.40625x123 table-box [TFC] children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <thead> at (8,8) content-size 113.40625x41.46875 table-header-group children: not-inline
|
||||
Box <thead> at (8,8) content-size 113.40625x41 table-header-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (8,8) content-size 113.40625x41.46875 table-row children: not-inline
|
||||
BlockContainer <td> at (29,19) content-size 16.265625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 9.59375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [29,19 9.59375x17.46875]
|
||||
Box <tr> at (8,8) content-size 113.40625x41 table-row children: not-inline
|
||||
BlockContainer <td> at (29,19) content-size 16.265625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 9.59375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [29,19 9.59375x17]
|
||||
"0"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (87.265625,19) content-size 13.140625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 6.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,19 6.34375x17.46875]
|
||||
BlockContainer <td> at (87.265625,19) content-size 13.140625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 6.34375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,19 6.34375x17]
|
||||
"1"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tbody.thick-border> at (8,49.46875) content-size 113.40625x82.9375 table-row-group children: not-inline
|
||||
Box <tbody.thick-border> at (8,49) content-size 113.40625x82 table-row-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (8,49.46875) content-size 113.40625x41.46875 table-row children: not-inline
|
||||
Box <tr> at (8,49) content-size 113.40625x41 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (31,62.46875) content-size 14.265625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,62.46875 14.265625x17.46875]
|
||||
BlockContainer <td> at (31,62) content-size 14.265625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,62 14.265625x17]
|
||||
"A"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (87.265625,62.46875) content-size 11.140625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,62.46875 9.34375x17.46875]
|
||||
BlockContainer <td> at (87.265625,62) content-size 11.140625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,62 9.34375x17]
|
||||
"B"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (8,90.9375) content-size 113.40625x41.46875 table-row children: not-inline
|
||||
Box <tr> at (8,90) content-size 113.40625x41 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (31,101.9375) content-size 14.265625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 10.3125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,101.9375 10.3125x17.46875]
|
||||
BlockContainer <td> at (31,101) content-size 14.265625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 10.3125, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [31,101 10.3125x17]
|
||||
"C"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (87.265625,101.9375) content-size 11.140625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 11.140625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,101.9375 11.140625x17.46875]
|
||||
BlockContainer <td> at (87.265625,101) content-size 11.140625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 11.140625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [87.265625,101 11.140625x17]
|
||||
"D"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
|
|
@ -71,23 +71,23 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
|
||||
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x124.40625]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 113.40625x124.40625]
|
||||
PaintableBox (Box<TABLE>) [8,8 113.40625x124.40625]
|
||||
PaintableBox (Box<THEAD>) [8,8 113.40625x41.46875]
|
||||
PaintableBox (Box<TR>) [8,8 113.40625x41.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,8 58.265625x41.46875]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x123]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 113.40625x123]
|
||||
PaintableBox (Box<TABLE>) [8,8 113.40625x123]
|
||||
PaintableBox (Box<THEAD>) [8,8 113.40625x41]
|
||||
PaintableBox (Box<TR>) [8,8 113.40625x41]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,8 58.265625x41]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,8 55.140625x41.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,8 55.140625x41]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TBODY>.thick-border) [8,49.46875 113.40625x82.9375]
|
||||
PaintableBox (Box<TR>) [8,49.46875 113.40625x41.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,49.46875 58.265625x41.46875]
|
||||
PaintableBox (Box<TBODY>.thick-border) [8,49 113.40625x82]
|
||||
PaintableBox (Box<TR>) [8,49 113.40625x41]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,49 58.265625x41]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,49.46875 55.140625x41.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,49 55.140625x41]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TR>) [8,90.9375 113.40625x41.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,90.9375 58.265625x41.46875]
|
||||
PaintableBox (Box<TR>) [8,90 113.40625x41]
|
||||
PaintableWithLines (BlockContainer<TD>) [8,90 58.265625x41]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,90.9375 55.140625x41.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [66.265625,90 55.140625x41]
|
||||
TextPaintable (TextNode<#text>)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue