mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 08:57:47 +00:00
LibWeb: Bring CSS line-height closer to other engines
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling
parent
f0722671c3
commit
e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
|
|
@ -1,28 +1,28 @@
|
|||
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
||||
BlockContainer <html> at (0,0) content-size 800x99.875 [BFC] children: not-inline
|
||||
BlockContainer <html> at (0,0) content-size 800x98 [BFC] children: not-inline
|
||||
BlockContainer <(anonymous)> at (0,0) content-size 800x0 children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <body> at (8,8) content-size 784x83.875 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 99.171875x83.875 [BFC] children: not-inline
|
||||
Box <table#full-table> at (8,8) content-size 99.171875x66.40625 table-box [TFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x82 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 99.171875x82 [BFC] children: not-inline
|
||||
Box <table#full-table> at (8,8) content-size 99.171875x65 table-box [TFC] children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <caption> at (8,74.40625) content-size 82.734375x17.46875 [BFC] children: inline
|
||||
line 0 width: 82.734375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 1, length: 9, rect: [16,74.40625 82.734375x17.46875]
|
||||
BlockContainer <caption> at (8,73) content-size 82.734375x17 [BFC] children: inline
|
||||
line 0 width: 82.734375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 1, length: 9, rect: [16,73 82.734375x17]
|
||||
"A Caption"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <thead> at (8,8) content-size 95.171875x19.46875 table-header-group children: not-inline
|
||||
Box <thead> at (8,8) content-size 95.171875x19 table-header-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (10,10) content-size 95.171875x19.46875 table-row children: not-inline
|
||||
Box <tr> at (10,10) content-size 95.171875x19 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (11,11) content-size 93.171875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 73.65625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 9, rect: [11,11 73.65625x17.46875]
|
||||
BlockContainer <td> at (11,11) content-size 93.171875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 73.65625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 9, rect: [11,11 73.65625x17]
|
||||
"Head Cell"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
|
|
@ -31,15 +31,15 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tbody> at (8,27.46875) content-size 95.171875x19.46875 table-row-group children: not-inline
|
||||
Box <tbody> at (8,27) content-size 95.171875x19 table-row-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (10,31.46875) content-size 95.171875x19.46875 table-row children: not-inline
|
||||
Box <tr> at (10,31) content-size 95.171875x19 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (11,32.46875) content-size 93.171875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 70.234375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 9, rect: [11,32.46875 70.234375x17.46875]
|
||||
BlockContainer <td> at (11,32) content-size 93.171875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 70.234375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 9, rect: [11,32 70.234375x17]
|
||||
"Body Cell"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
|
|
@ -48,15 +48,15 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tfoot> at (8,46.9375) content-size 95.171875x19.46875 table-footer-group children: not-inline
|
||||
Box <tfoot> at (8,46) content-size 95.171875x19 table-footer-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (10,52.9375) content-size 95.171875x19.46875 table-row children: not-inline
|
||||
Box <tr> at (10,52) content-size 95.171875x19 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (11,53.9375) content-size 93.171875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 93.171875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 11, rect: [11,53.9375 93.171875x17.46875]
|
||||
BlockContainer <td> at (11,53) content-size 93.171875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 93.171875, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 11, rect: [11,53 93.171875x17]
|
||||
"Footer Cell"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
|
|
@ -65,27 +65,27 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> at (8,91.875) content-size 784x0 children: inline
|
||||
BlockContainer <(anonymous)> at (8,90) content-size 784x0 children: inline
|
||||
TextNode <#text>
|
||||
|
||||
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x99.875]
|
||||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x98]
|
||||
PaintableWithLines (BlockContainer(anonymous)) [0,0 800x0]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x83.875]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 99.171875x83.875]
|
||||
PaintableBox (Box<TABLE>#full-table) [8,8 99.171875x66.40625] overflow: [8,8 99.171875x83.875]
|
||||
PaintableWithLines (BlockContainer<CAPTION>) [8,74.40625 82.734375x17.46875] overflow: [8,74.40625 90.734375x17.46875]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x82]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 99.171875x82]
|
||||
PaintableBox (Box<TABLE>#full-table) [8,8 99.171875x65] overflow: [8,8 99.171875x82]
|
||||
PaintableWithLines (BlockContainer<CAPTION>) [8,73 82.734375x17] overflow: [8,73 90.734375x17]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<THEAD>) [8,8 95.171875x19.46875] overflow: [8,8 97.171875x21.46875]
|
||||
PaintableBox (Box<TR>) [10,10 95.171875x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,10 95.171875x19.46875]
|
||||
PaintableBox (Box<THEAD>) [8,8 95.171875x19] overflow: [8,8 97.171875x21]
|
||||
PaintableBox (Box<TR>) [10,10 95.171875x19]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,10 95.171875x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TBODY>) [8,27.46875 95.171875x19.46875] overflow: [8,27.46875 97.171875x23.46875]
|
||||
PaintableBox (Box<TR>) [10,31.46875 95.171875x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,31.46875 95.171875x19.46875]
|
||||
PaintableBox (Box<TBODY>) [8,27 95.171875x19] overflow: [8,27 97.171875x23]
|
||||
PaintableBox (Box<TR>) [10,31 95.171875x19]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,31 95.171875x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TFOOT>) [8,46.9375 95.171875x19.46875] overflow: [8,46.9375 97.171875x25.46875]
|
||||
PaintableBox (Box<TR>) [10,52.9375 95.171875x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,52.9375 95.171875x19.46875]
|
||||
PaintableBox (Box<TFOOT>) [8,46 95.171875x19] overflow: [8,46 97.171875x25]
|
||||
PaintableBox (Box<TR>) [10,52 95.171875x19]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,52 95.171875x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer(anonymous)) [8,91.875 784x0]
|
||||
PaintableWithLines (BlockContainer(anonymous)) [8,90 784x0]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue