mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 10:47:35 +00:00
LibWeb: Bring CSS line-height closer to other engines
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling
parent
f0722671c3
commit
e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
|
|
@ -1,59 +1,59 @@
|
|||
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
||||
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x44.9375 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 784x44.9375 [BFC] children: not-inline
|
||||
Box <table> at (8,8) content-size 784x44.9375 table-box [TFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x44 children: not-inline
|
||||
TableWrapper <(anonymous)> at (8,8) content-size 784x44 [BFC] children: not-inline
|
||||
Box <table> at (8,8) content-size 784x44 table-box [TFC] children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tbody> at (8,8) content-size 776x38.9375 table-row-group children: not-inline
|
||||
Box <tbody> at (8,8) content-size 776x38 table-row-group children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (10,10) content-size 776x19.46875 table-row children: not-inline
|
||||
Box <tr> at (10,10) content-size 776x19 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <th> at (11,11) content-size 300.640625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [154,11 14.265625x17.46875]
|
||||
BlockContainer <th> at (11,11) content-size 300.640625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [154,11 14.265625x17]
|
||||
"A"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <th> at (315.640625,11) content-size 168.71875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [395.640625,11 9.34375x17.46875]
|
||||
BlockContainer <th> at (315.640625,11) content-size 168.71875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [395.640625,11 9.34375x17]
|
||||
"B"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <th> at (488.359375,11) content-size 300.640625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 29.453125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 3, rect: [624.359375,11 29.453125x17.46875]
|
||||
BlockContainer <th> at (488.359375,11) content-size 300.640625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 29.453125, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 3, rect: [624.359375,11 29.453125x17]
|
||||
"C D"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
Box <tr> at (10,31.46875) content-size 776x19.46875 table-row children: not-inline
|
||||
Box <tr> at (10,31) content-size 776x19 table-row children: not-inline
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (11,32.46875) content-size 300.640625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 11.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [155,32.46875 11.859375x17.46875]
|
||||
BlockContainer <td> at (11,32) content-size 300.640625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 11.859375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [155,32 11.859375x17]
|
||||
"E"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (315.640625,32.46875) content-size 168.71875x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 12.546875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [393.640625,32.46875 12.546875x17.46875]
|
||||
BlockContainer <td> at (315.640625,32) content-size 168.71875x17 table-cell [BFC] children: inline
|
||||
line 0 width: 12.546875, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [393.640625,32 12.546875x17]
|
||||
"F"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (488.359375,32.46875) content-size 300.640625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 13.234375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [632.359375,32.46875 13.234375x17.46875]
|
||||
BlockContainer <td> at (488.359375,32) content-size 300.640625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 13.234375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 1, rect: [632.359375,32 13.234375x17]
|
||||
"G"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> (not painted) children: inline
|
||||
|
|
@ -65,21 +65,21 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
|
||||
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x44.9375]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 784x44.9375]
|
||||
PaintableBox (Box<TABLE>) [8,8 784x44.9375]
|
||||
PaintableBox (Box<TBODY>) [8,8 776x38.9375] overflow: [8,8 782x42.9375]
|
||||
PaintableBox (Box<TR>) [10,10 776x19.46875] overflow: [10,10 780x19.46875]
|
||||
PaintableWithLines (BlockContainer<TH>) [10,10 302.640625x19.46875]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x44]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [8,8 784x44]
|
||||
PaintableBox (Box<TABLE>) [8,8 784x44]
|
||||
PaintableBox (Box<TBODY>) [8,8 776x38] overflow: [8,8 782x42]
|
||||
PaintableBox (Box<TR>) [10,10 776x19] overflow: [10,10 780x19]
|
||||
PaintableWithLines (BlockContainer<TH>) [10,10 302.640625x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TH>) [314.640625,10 170.71875x19.46875]
|
||||
PaintableWithLines (BlockContainer<TH>) [314.640625,10 170.71875x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TH>) [487.359375,10 302.640625x19.46875]
|
||||
PaintableWithLines (BlockContainer<TH>) [487.359375,10 302.640625x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TR>) [10,31.46875 776x19.46875] overflow: [10,31.46875 780x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,31.46875 302.640625x19.46875]
|
||||
PaintableBox (Box<TR>) [10,31 776x19] overflow: [10,31 780x19]
|
||||
PaintableWithLines (BlockContainer<TD>) [10,31 302.640625x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [314.640625,31.46875 170.71875x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [314.640625,31 170.71875x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [487.359375,31.46875 302.640625x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [487.359375,31 302.640625x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue