RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:47:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

48
Tests/LibWeb/Layout/expected/table/colspan-weighted-width-distribution.txt
View file

@ -1,36 +1,36 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x44.9375 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 210x44.9375 [BFC] children: not-inline
Box <table> at (9,9) content-size 208x42.9375 table-box [TFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x44 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 210x44 [BFC] children: not-inline
Box <table> at (9,9) content-size 208x42 table-box [TFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tbody> at (9,9) content-size 208x42.9375 table-row-group children: not-inline
Box <tr> at (9,9) content-size 208x21.46875 table-row children: not-inline
Box <tbody> at (9,9) content-size 208x42 table-row-group children: not-inline
Box <tr> at (9,9) content-size 208x21 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,11) content-size 180x17.46875 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [94,11 14.265625x17.46875]
BlockContainer <td> at (11,11) content-size 180x17 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [94,11 14.265625x17]
"A"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (195,11) content-size 20x17.46875 table-cell [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [200,11 9.34375x17.46875]
BlockContainer <td> at (195,11) content-size 20x17 table-cell [BFC] children: inline
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [200,11 9.34375x17]
"B"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (9,30.46875) content-size 208x21.46875 table-row children: not-inline
Box <tr> at (9,30) content-size 208x21 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,32.46875) content-size 204x17.46875 table-cell [BFC] children: inline
line 0 width: 10.3125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [108,32.46875 10.3125x17.46875]
BlockContainer <td> at (11,32) content-size 204x17 table-cell [BFC] children: inline
line 0 width: 10.3125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [108,32 10.3125x17]
"C"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -40,15 +40,15 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x44.9375]
PaintableWithLines (TableWrapper(anonymous)) [8,8 210x44.9375]
PaintableBox (Box<TABLE>) [8,8 210x44.9375]
PaintableBox (Box<TBODY>) [9,9 208x42.9375]
PaintableBox (Box<TR>) [9,9 208x21.46875]
PaintableWithLines (BlockContainer<TD>) [9,9 184x21.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x44]
PaintableWithLines (TableWrapper(anonymous)) [8,8 210x44]
PaintableBox (Box<TABLE>) [8,8 210x44]
PaintableBox (Box<TBODY>) [9,9 208x42]
PaintableBox (Box<TR>) [9,9 208x21]
PaintableWithLines (BlockContainer<TD>) [9,9 184x21]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [193,9 24x21.46875]
PaintableWithLines (BlockContainer<TD>) [193,9 24x21]
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [9,30.46875 208x21.46875]
PaintableWithLines (BlockContainer<TD>) [9,30.46875 208x21.46875]
PaintableBox (Box<TR>) [9,30 208x21]
PaintableWithLines (BlockContainer<TD>) [9,30 208x21]
TextPaintable (TextNode<#text>)