RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

56
Tests/LibWeb/Layout/expected/table/columns-width-distribution-1.txt
View file

@ -1,43 +1,43 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x113.15625 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 784x113.15625 [BFC] children: not-inline
Box <table.ambox> at (9,9) content-size 782x111.15625 table-box [TFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x110 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 784x110 [BFC] children: not-inline
Box <table.ambox> at (9,9) content-size 782x108 table-box [TFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tbody> at (9,9) content-size 776x107.15625 table-row-group children: not-inline
Box <tr> at (11,11) content-size 776x107.15625 table-row children: not-inline
BlockContainer <td.mbox-image> at (12,39.578125) content-size 50x50 table-cell [BFC] children: not-inline
BlockContainer <div.mbox-image-div> at (12,39.578125) content-size 50x50 children: not-inline
BlockContainer <td.mbox-text> at (66,12) content-size 722x105.15625 table-cell [BFC] children: inline
line 0 width: 689.640625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 84, rect: [66,12 689.640625x17.46875]
Box <tbody> at (9,9) content-size 776x104 table-row-group children: not-inline
Box <tr> at (11,11) content-size 776x104 table-row children: not-inline
BlockContainer <td.mbox-image> at (12,38) content-size 50x50 table-cell [BFC] children: not-inline
BlockContainer <div.mbox-image-div> at (12,38) content-size 50x50 children: not-inline
BlockContainer <td.mbox-text> at (66,12) content-size 722x102 table-cell [BFC] children: inline
line 0 width: 689.640625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 1, length: 84, rect: [66,12 689.640625x17]
"In a scene set in a lawyer's office, the lawyer sits alone and bounces a rubber ball"
line 1 width: 695.5625, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 86, length: 84, rect: [66,29 695.5625x17.46875]
line 1 width: 695.5625, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 86, length: 84, rect: [66,29 695.5625x17]
"against the wall. They receive a call from their assistant who expresses frustration"
line 2 width: 703.125, height: 18.40625, bottom: 53.34375, baseline: 13.53125
frag 0 from TextNode start: 171, length: 85, rect: [66,46 703.125x17.46875]
line 2 width: 703.125, height: 17, bottom: 51, baseline: 13.296875
frag 0 from TextNode start: 171, length: 85, rect: [66,46 703.125x17]
"over a packed waiting room and the lawyer's lack of clients. The lawyer then looks at"
line 3 width: 695.90625, height: 17.875, bottom: 70.28125, baseline: 13.53125
frag 0 from TextNode start: 257, length: 81, rect: [66,64 695.90625x17.46875]
line 3 width: 695.90625, height: 17, bottom: 68, baseline: 13.296875
frag 0 from TextNode start: 257, length: 81, rect: [66,63 695.90625x17]
"some papers from a large envelope, which turn out to be divorce papers from their"
line 4 width: 670.515625, height: 18.34375, bottom: 88.21875, baseline: 13.53125
frag 0 from TextNode start: 339, length: 84, rect: [66,81 670.515625x17.46875]
line 4 width: 670.515625, height: 17, bottom: 85, baseline: 13.296875
frag 0 from TextNode start: 339, length: 84, rect: [66,80 670.515625x17]
"significant other. Finally, the lawyer instructs their assistant to send in the next"
line 5 width: 47.21875, height: 17.8125, bottom: 105.15625, baseline: 13.53125
frag 0 from TextNode start: 424, length: 7, rect: [66,99 47.21875x17.46875]
line 5 width: 47.21875, height: 17, bottom: 102, baseline: 13.296875
frag 0 from TextNode start: 424, length: 7, rect: [66,97 47.21875x17]
"client."
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x113.15625]
PaintableWithLines (TableWrapper(anonymous)) [8,8 784x113.15625]
PaintableBox (Box<TABLE>.ambox) [8,8 784x113.15625]
PaintableBox (Box<TBODY>) [9,9 776x107.15625] overflow: [9,9 780x109.15625]
PaintableBox (Box<TR>) [11,11 776x107.15625] overflow: [11,11 778x107.15625]
PaintableWithLines (BlockContainer<TD>.mbox-image) [11,11 52x107.15625]
PaintableWithLines (BlockContainer<DIV>.mbox-image-div) [12,39.578125 50x50]
PaintableWithLines (BlockContainer<TD>.mbox-text) [65,11 724x107.15625]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x110]
PaintableWithLines (TableWrapper(anonymous)) [8,8 784x110]
PaintableBox (Box<TABLE>.ambox) [8,8 784x110]
PaintableBox (Box<TBODY>) [9,9 776x104] overflow: [9,9 780x106]
PaintableBox (Box<TR>) [11,11 776x104] overflow: [11,11 778x104]
PaintableWithLines (BlockContainer<TD>.mbox-image) [11,11 52x104]
PaintableWithLines (BlockContainer<DIV>.mbox-image-div) [12,38 50x50]
PaintableWithLines (BlockContainer<TD>.mbox-text) [65,11 724x104]
TextPaintable (TextNode<#text>)