RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:27:44 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Tests/LibWeb/Layout/expected/table/fixed-margins.txt
View file

@ -1,25 +1,25 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x35.40625 children: not-inline
BlockContainer <div.wrapper> at (8,8) content-size 784x35.40625 children: not-inline
TableWrapper <(anonymous)> at (108,8) content-size 584x35.40625 [BFC] children: not-inline
Box <div.box> at (108,8) content-size 584x35.40625 table-box [TFC] children: not-inline
Box <(anonymous)> at (108,8) content-size 584x35.40625 table-row children: not-inline
BlockContainer <div.cell> at (108,8) content-size 584x35.40625 table-cell [BFC] children: inline
line 0 width: 569.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 58, rect: [108,8 569.859375x17.46875]
BlockContainer <body> at (8,8) content-size 784x34 children: not-inline
BlockContainer <div.wrapper> at (8,8) content-size 784x34 children: not-inline
TableWrapper <(anonymous)> at (108,8) content-size 584x34 [BFC] children: not-inline
Box <div.box> at (108,8) content-size 584x34 table-box [TFC] children: not-inline
Box <(anonymous)> at (108,8) content-size 584x34 table-row children: not-inline
BlockContainer <div.cell> at (108,8) content-size 584x34 table-cell [BFC] children: inline
line 0 width: 569.859375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 58, rect: [108,8 569.859375x17]
"DaTa DisplaYiNg CSS WeBpaGE ScReEn OF aR AddITioN COmmOnLY"
line 1 width: 399.9375, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 59, length: 40, rect: [108,25 399.9375x17.46875]
line 1 width: 399.9375, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 59, length: 40, rect: [108,25 399.9375x17]
"To AdJuSt PRiCiNG sTYLiNG ceLL oF TAbLeS"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x35.40625]
PaintableWithLines (BlockContainer<DIV>.wrapper) [8,8 784x35.40625]
PaintableWithLines (TableWrapper(anonymous)) [108,8 584x35.40625]
PaintableBox (Box<DIV>.box) [108,8 584x35.40625]
PaintableBox (Box(anonymous)) [108,8 584x35.40625]
PaintableWithLines (BlockContainer<DIV>.cell) [108,8 584x35.40625]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34]
PaintableWithLines (BlockContainer<DIV>.wrapper) [8,8 784x34]
PaintableWithLines (TableWrapper(anonymous)) [108,8 584x34]
PaintableBox (Box<DIV>.box) [108,8 584x34]
PaintableBox (Box(anonymous)) [108,8 584x34]
PaintableWithLines (BlockContainer<DIV>.cell) [108,8 584x34]
TextPaintable (TextNode<#text>)