mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 02:17:34 +00:00
LibWeb: Bring CSS line-height closer to other engines
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling
parent
f0722671c3
commit
e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
|
|
@ -1,49 +1,49 @@
|
|||
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
||||
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x46.9375 children: inline
|
||||
line 0 width: 137.984375, height: 46.9375, bottom: 46.9375, baseline: 39
|
||||
frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 135.984375x44.9375]
|
||||
BlockContainer <table> at (9,9) content-size 135.984375x44.9375 inline-block [BFC] children: not-inline
|
||||
TableWrapper <(anonymous)> at (9,9) content-size 135.984375x44.9375 inline-block [BFC] children: not-inline
|
||||
Box <(anonymous)> at (9,9) content-size 135.984375x44.9375 inline-table table-box [TFC] children: not-inline
|
||||
Box <tbody> at (9,9) content-size 129.984375x38.9375 table-row-group children: not-inline
|
||||
Box <tr> at (11,11) content-size 129.984375x19.46875 table-row children: not-inline
|
||||
BlockContainer <td> at (12,12) content-size 87.90625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 15.734375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 2, rect: [12,12 15.734375x17.46875]
|
||||
BlockContainer <body> at (8,8) content-size 784x46 children: inline
|
||||
line 0 width: 137.984375, height: 46, bottom: 46, baseline: 38.296875
|
||||
frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 135.984375x44]
|
||||
BlockContainer <table> at (9,9) content-size 135.984375x44 inline-block [BFC] children: not-inline
|
||||
TableWrapper <(anonymous)> at (9,9) content-size 135.984375x44 inline-block [BFC] children: not-inline
|
||||
Box <(anonymous)> at (9,9) content-size 135.984375x44 inline-table table-box [TFC] children: not-inline
|
||||
Box <tbody> at (9,9) content-size 129.984375x38 table-row-group children: not-inline
|
||||
Box <tr> at (11,11) content-size 129.984375x19 table-row children: not-inline
|
||||
BlockContainer <td> at (12,12) content-size 87.90625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 15.734375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 2, rect: [12,12 15.734375x17]
|
||||
"ID"
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (103.90625,12) content-size 38.078125x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 27.84375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 4, rect: [103.90625,12 27.84375x17.46875]
|
||||
BlockContainer <td> at (103.90625,12) content-size 38.078125x17 table-cell [BFC] children: inline
|
||||
line 0 width: 27.84375, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 4, rect: [103.90625,12 27.84375x17]
|
||||
"null"
|
||||
TextNode <#text>
|
||||
Box <tr> at (11,32.46875) content-size 129.984375x19.46875 table-row children: not-inline
|
||||
BlockContainer <td> at (12,33.46875) content-size 87.90625x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 87.90625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 11, rect: [12,33.46875 87.90625x17.46875]
|
||||
Box <tr> at (11,32) content-size 129.984375x19 table-row children: not-inline
|
||||
BlockContainer <td> at (12,33) content-size 87.90625x17 table-cell [BFC] children: inline
|
||||
line 0 width: 87.90625, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 11, rect: [12,33 87.90625x17]
|
||||
"Is Selected"
|
||||
TextNode <#text>
|
||||
BlockContainer <td> at (103.90625,33.46875) content-size 38.078125x17.46875 table-cell [BFC] children: inline
|
||||
line 0 width: 38.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [103.90625,33.46875 38.078125x17.46875]
|
||||
BlockContainer <td> at (103.90625,33) content-size 38.078125x17 table-cell [BFC] children: inline
|
||||
line 0 width: 38.078125, height: 17, bottom: 17, baseline: 13.296875
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [103.90625,33 38.078125x17]
|
||||
"false"
|
||||
TextNode <#text>
|
||||
|
||||
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x46.9375]
|
||||
PaintableWithLines (BlockContainer<TABLE>) [8,8 137.984375x46.9375]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [9,9 135.984375x44.9375]
|
||||
PaintableBox (Box(anonymous)) [9,9 135.984375x44.9375]
|
||||
PaintableBox (Box<TBODY>) [9,9 129.984375x38.9375] overflow: [9,9 133.984375x42.9375]
|
||||
PaintableBox (Box<TR>) [11,11 129.984375x19.46875] overflow: [11,11 131.984375x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [11,11 89.90625x19.46875]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x46]
|
||||
PaintableWithLines (BlockContainer<TABLE>) [8,8 137.984375x46]
|
||||
PaintableWithLines (TableWrapper(anonymous)) [9,9 135.984375x44]
|
||||
PaintableBox (Box(anonymous)) [9,9 135.984375x44]
|
||||
PaintableBox (Box<TBODY>) [9,9 129.984375x38] overflow: [9,9 133.984375x42]
|
||||
PaintableBox (Box<TR>) [11,11 129.984375x19] overflow: [11,11 131.984375x19]
|
||||
PaintableWithLines (BlockContainer<TD>) [11,11 89.90625x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [102.90625,11 40.078125x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [102.90625,11 40.078125x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableBox (Box<TR>) [11,32.46875 129.984375x19.46875] overflow: [11,32.46875 131.984375x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [11,32.46875 89.90625x19.46875]
|
||||
PaintableBox (Box<TR>) [11,32 129.984375x19] overflow: [11,32 131.984375x19]
|
||||
PaintableWithLines (BlockContainer<TD>) [11,32 89.90625x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<TD>) [102.90625,32.46875 40.078125x19.46875]
|
||||
PaintableWithLines (BlockContainer<TD>) [102.90625,32 40.078125x19]
|
||||
TextPaintable (TextNode<#text>)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue