1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:27:35 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -1,57 +1,57 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x120.40625 children: not-inline
Box <div> at (8,8) content-size 784x120.40625 [GFC] children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 100x120.40625 [BFC] children: not-inline
Box <table> at (9,9) content-size 98x118.40625 table-box [TFC] children: not-inline
Box <tbody> at (9,9) content-size 98x118.40625 table-row-group children: not-inline
Box <tr> at (9,9) content-size 98x39.46875 table-row children: not-inline
BlockContainer <td> at (20,20) content-size 30.5625x17.46875 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [20,20 14.265625x17.46875]
BlockContainer <body> at (8,8) content-size 784x119 children: not-inline
Box <div> at (8,8) content-size 784x119 [GFC] children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 100x119 [BFC] children: not-inline
Box <table> at (9,9) content-size 98x117 table-box [TFC] children: not-inline
Box <tbody> at (9,9) content-size 98x117 table-row-group children: not-inline
Box <tr> at (9,9) content-size 98x39 table-row children: not-inline
BlockContainer <td> at (20,20) content-size 30.5625x17 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [20,20 14.265625x17]
"A"
TextNode <#text>
BlockContainer <td> at (72.5625,20) content-size 23.4375x17.46875 table-cell [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [72.5625,20 9.34375x17.46875]
BlockContainer <td> at (72.5625,20) content-size 23.4375x17 table-cell [BFC] children: inline
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [72.5625,20 9.34375x17]
"B"
TextNode <#text>
Box <tr> at (9,48.46875) content-size 98x39.46875 table-row children: not-inline
BlockContainer <td> at (20,59.46875) content-size 30.5625x17.46875 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [20,59.46875 14.265625x17.46875]
Box <tr> at (9,48) content-size 98x39 table-row children: not-inline
BlockContainer <td> at (20,59) content-size 30.5625x17 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [20,59 14.265625x17]
"A"
TextNode <#text>
BlockContainer <(anonymous)> at (62.5625,68.703125) content-size 21.71875x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> at (84.28125,68.203125) content-size 21.71875x0 table-cell [BFC] children: not-inline
Box <tr> at (9,87.9375) content-size 98x39.46875 table-row children: not-inline
BlockContainer <td> at (20,98.9375) content-size 30.5625x17.46875 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [20,98.9375 14.265625x17.46875]
BlockContainer <(anonymous)> at (62.5625,68) content-size 21.71875x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> at (84.28125,67.5) content-size 21.71875x0 table-cell [BFC] children: not-inline
Box <tr> at (9,87) content-size 98x39 table-row children: not-inline
BlockContainer <td> at (20,98) content-size 30.5625x17 table-cell [BFC] children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [20,98 14.265625x17]
"A"
TextNode <#text>
BlockContainer <(anonymous)> at (62.5625,107.171875) content-size 21.71875x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> at (84.28125,107.171875) content-size 21.71875x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> at (62.5625,106) content-size 21.71875x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> at (84.28125,106) content-size 21.71875x0 table-cell [BFC] children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x120.40625]
PaintableBox (Box<DIV>) [8,8 784x120.40625]
PaintableWithLines (TableWrapper(anonymous)) [8,8 100x120.40625]
PaintableBox (Box<TABLE>) [8,8 100x120.40625]
PaintableBox (Box<TBODY>) [9,9 98x118.40625]
PaintableBox (Box<TR>) [9,9 98x39.46875]
PaintableWithLines (BlockContainer<TD>) [9,9 52.5625x39.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x119]
PaintableBox (Box<DIV>) [8,8 784x119]
PaintableWithLines (TableWrapper(anonymous)) [8,8 100x119]
PaintableBox (Box<TABLE>) [8,8 100x119]
PaintableBox (Box<TBODY>) [9,9 98x117]
PaintableBox (Box<TR>) [9,9 98x39]
PaintableWithLines (BlockContainer<TD>) [9,9 52.5625x39]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [61.5625,9 45.4375x39.46875]
PaintableWithLines (BlockContainer<TD>) [61.5625,9 45.4375x39]
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [9,48.46875 98x39.46875]
PaintableWithLines (BlockContainer<TD>) [9,48.46875 52.5625x39.46875]
PaintableBox (Box<TR>) [9,48 98x39]
PaintableWithLines (BlockContainer<TD>) [9,48 52.5625x39]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [61.5625,48.46875 22.71875x39.46875]
PaintableWithLines (BlockContainer(anonymous)) [84.28125,48.46875 22.71875x39.46875]
PaintableBox (Box<TR>) [9,87.9375 98x39.46875]
PaintableWithLines (BlockContainer<TD>) [9,87.9375 52.5625x39.46875]
PaintableWithLines (BlockContainer(anonymous)) [61.5625,48 22.71875x39]
PaintableWithLines (BlockContainer(anonymous)) [84.28125,48 22.71875x39]
PaintableBox (Box<TR>) [9,87 98x39]
PaintableWithLines (BlockContainer<TD>) [9,87 52.5625x39]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [61.5625,87.9375 22.71875x39.46875]
PaintableWithLines (BlockContainer(anonymous)) [84.28125,87.9375 22.71875x39.46875]
PaintableWithLines (BlockContainer(anonymous)) [61.5625,87 22.71875x39]
PaintableWithLines (BlockContainer(anonymous)) [84.28125,87 22.71875x39]