RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:57:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Tests/LibWeb/Layout/expected/table/row-outer-size-with-computed-size.txt
View file

@ -1,20 +1,20 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x25.46875 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 49.21875x25.46875 [BFC] children: not-inline
Box <table> at (8,8) content-size 49.21875x25.46875 table-box [TFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x25 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 49.21875x25 [BFC] children: not-inline
Box <table> at (8,8) content-size 49.21875x25 table-box [TFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tbody> at (8,8) content-size 43.21875x19.46875 table-row-group children: not-inline
Box <tr> at (10,10) content-size 43.21875x9.734375 table-row children: not-inline
Box <tbody> at (8,8) content-size 43.21875x19 table-row-group children: not-inline
Box <tr> at (10,10) content-size 43.21875x9.5 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,14.859375) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <td> at (11,14.75) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (16,12) content-size 37.21875x17.46875 table-cell [BFC] children: inline
line 0 width: 37.21875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [16,12 37.21875x17.46875]
BlockContainer <td> at (16,12) content-size 37.21875x17 table-cell [BFC] children: inline
line 0 width: 37.21875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 4, rect: [16,12 37.21875x17]
"Test"
TextNode <#text>
InlineNode <a>
@ -24,10 +24,10 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (10,21.734375) content-size 43.21875x9.734375 table-row children: not-inline
Box <tr> at (10,21.5) content-size 43.21875x9.5 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,26.59375) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <td> at (11,26.25) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -35,14 +35,14 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x25.46875]
PaintableWithLines (TableWrapper(anonymous)) [8,8 49.21875x25.46875]
PaintableBox (Box<TABLE>) [8,8 49.21875x25.46875]
PaintableBox (Box<TBODY>) [8,8 43.21875x19.46875] overflow: [8,8 47.21875x23.46875]
PaintableBox (Box<TR>) [10,10 43.21875x9.734375] overflow: [10,10 45.21875x21.46875]
PaintableWithLines (BlockContainer<TD>) [10,10 2x9.71875]
PaintableWithLines (BlockContainer<TD>) [14,10 41.21875x21.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x25]
PaintableWithLines (TableWrapper(anonymous)) [8,8 49.21875x25]
PaintableBox (Box<TABLE>) [8,8 49.21875x25]
PaintableBox (Box<TBODY>) [8,8 43.21875x19] overflow: [8,8 47.21875x23]
PaintableBox (Box<TR>) [10,10 43.21875x9.5] overflow: [10,10 45.21875x21]
PaintableWithLines (BlockContainer<TD>) [10,10 2x9.5]
PaintableWithLines (BlockContainer<TD>) [14,10 41.21875x21]
InlinePaintable (InlineNode<A>)
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [10,21.734375 43.21875x9.734375]
PaintableWithLines (BlockContainer<TD>) [10,21.734375 2x9.71875]
PaintableBox (Box<TR>) [10,21.5 43.21875x9.5]
PaintableWithLines (BlockContainer<TD>) [10,21.5 2x9.5]