RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:37:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Tests/LibWeb/Layout/expected/table/table-cellpadding.txt
View file

@ -5,19 +5,19 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <table> at (9,9) content-size 496.1875x202 table-box [TFC] children: not-inline
Box <tbody> at (9,9) content-size 488.1875x198 table-row-group children: not-inline
Box <tr> at (11,11) content-size 488.1875x198 table-row children: not-inline
BlockContainer <td> at (71,71) content-size 26.640625x17.46875 table-cell [BFC] children: inline
line 0 width: 26.640625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [71,71 26.640625x17.46875]
BlockContainer <td> at (71,71) content-size 26.640625x17 table-cell [BFC] children: inline
line 0 width: 26.640625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [71,71 26.640625x17]
"top"
TextNode <#text>
BlockContainer <td> at (219.640625,101.265625) content-size 45.4375x17.46875 table-cell [BFC] children: inline
line 0 width: 45.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [219.640625,101.265625 45.4375x17.46875]
BlockContainer <td> at (219.640625,101.5) content-size 45.4375x17 table-cell [BFC] children: inline
line 0 width: 45.4375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [219.640625,101.5 45.4375x17]
"middle"
TextNode <#text>
BlockContainer <td> at (387.078125,131.53125) content-size 56.109375x17.46875 table-cell [BFC] children: inline
line 0 width: 56.109375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [387.078125,131.53125 56.109375x17.46875]
BlockContainer <td> at (387.078125,132) content-size 56.109375x17 table-cell [BFC] children: inline
line 0 width: 56.109375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [387.078125,132 56.109375x17]
"bottom"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline