RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 17:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

48
Tests/LibWeb/Layout/expected/textarea-content.txt
View file

@ -1,38 +1,38 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x65.6875 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x49.6875 children: inline
line 0 width: 502, height: 49.6875, bottom: 49.6875, baseline: 16.921875
frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 240x43.6875]
frag 1 from TextNode start: 0, length: 1, rect: [254,8 10x21.84375]
BlockContainer <html> at (0,0) content-size 800x66 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x50 children: inline
line 0 width: 502, height: 50, bottom: 50, baseline: 17
frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 240x44]
frag 1 from TextNode start: 0, length: 1, rect: [254,8 10x22]
" "
frag 2 from BlockContainer start: 0, length: 0, rect: [267,11 240x43.6875]
frag 2 from BlockContainer start: 0, length: 0, rect: [267,11 240x44]
TextNode <#text>
BlockContainer <textarea> at (11,11) content-size 240x43.6875 inline-block [BFC] children: not-inline
BlockContainer <div> at (11,11) content-size 240x21.84375 children: not-inline
BlockContainer <div> at (11,11) content-size 240x21.84375 children: inline
line 0 width: 190.265625, height: 21.84375, bottom: 21.84375, baseline: 16.921875
frag 0 from TextNode start: 0, length: 17, rect: [11,11 190.265625x21.84375]
BlockContainer <textarea> at (11,11) content-size 240x44 inline-block [BFC] children: not-inline
BlockContainer <div> at (11,11) content-size 240x22 children: not-inline
BlockContainer <div> at (11,11) content-size 240x22 children: inline
line 0 width: 190.265625, height: 22, bottom: 22, baseline: 17
frag 0 from TextNode start: 0, length: 17, rect: [11,11 190.265625x22]
"Bonjour mon amis!"
TextNode <#text>
TextNode <#text>
BlockContainer <textarea> at (267,11) content-size 240x43.6875 inline-block [BFC] children: not-inline
BlockContainer <div> at (267,11) content-size 240x21.84375 children: not-inline
BlockContainer <div> at (267,11) content-size 240x21.84375 children: inline
line 0 width: 177.6875, height: 21.84375, bottom: 21.84375, baseline: 16.921875
frag 0 from TextNode start: 0, length: 19, rect: [267,11 177.6875x21.84375]
BlockContainer <textarea> at (267,11) content-size 240x44 inline-block [BFC] children: not-inline
BlockContainer <div> at (267,11) content-size 240x22 children: not-inline
BlockContainer <div> at (267,11) content-size 240x22 children: inline
line 0 width: 177.6875, height: 22, bottom: 22, baseline: 17
frag 0 from TextNode start: 0, length: 19, rect: [267,11 177.6875x22]
"Well hello friends!"
TextNode <#text>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x65.6875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x49.6875]
PaintableWithLines (BlockContainer<TEXTAREA>) [8,8 246x49.6875]
PaintableWithLines (BlockContainer<DIV>) [11,11 240x21.84375]
PaintableWithLines (BlockContainer<DIV>) [11,11 240x21.84375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x66]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x50]
PaintableWithLines (BlockContainer<TEXTAREA>) [8,8 246x50]
PaintableWithLines (BlockContainer<DIV>) [11,11 240x22]
PaintableWithLines (BlockContainer<DIV>) [11,11 240x22]
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TEXTAREA>) [264,8 246x49.6875]
PaintableWithLines (BlockContainer<DIV>) [267,11 240x21.84375]
PaintableWithLines (BlockContainer<DIV>) [267,11 240x21.84375]
PaintableWithLines (BlockContainer<TEXTAREA>) [264,8 246x50]
PaintableWithLines (BlockContainer<DIV>) [267,11 240x22]
PaintableWithLines (BlockContainer<DIV>) [267,11 240x22]
TextPaintable (TextNode<#text>)