RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:57:44 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Layout/expected/vertical-padding-relative-to-cb-width.txt
View file

@ -7,23 +7,23 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <(anonymous)> at (11,11) content-size 600x0 children: inline
TextNode <#text>
BlockContainer <div.foo> at (12,72) content-size 598x18 children: inline
line 0 width: 27.15625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [12,72 27.15625x17.46875]
line 0 width: 27.15625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [12,72 27.15625x17]
"foo"
TextNode <#text>
BlockContainer <(anonymous)> at (11,211) content-size 600x17.46875 children: inline
line 0 width: 27.640625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [11,211 27.640625x17.46875]
BlockContainer <(anonymous)> at (11,211) content-size 600x17 children: inline
line 0 width: 27.640625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 1, length: 3, rect: [11,211 27.640625x17]
"bar"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 800x602]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x602]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x14] overflow: [10,10 780x218.46875]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x14] overflow: [10,10 780x218]
PaintableWithLines (BlockContainer(anonymous)) [10,10 780x0]
PaintableWithLines (BlockContainer<DIV>.cb) [10,10 602x12] overflow: [11,11 600x217.46875]
PaintableWithLines (BlockContainer<DIV>.cb) [10,10 602x12] overflow: [11,11 600x217]
PaintableWithLines (BlockContainer(anonymous)) [11,11 600x0]
PaintableWithLines (BlockContainer<DIV>.foo) [11,11 600x200]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [11,211 600x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [11,211 600x17]
TextPaintable (TextNode<#text>)