LibWeb: Bring CSS line-height closer to other engines

Browse source

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.

...

This commit is contained in:

Andreas Kling 2024-01-12 12:39:40 +01:00

parent f0722671c3

commit e7de5cb4d2

385 changed files with 6889 additions and 6893 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

BIN

Tests/LibWeb/Ref/reference/images/input-placeholder-ref.png

View file

Binary file not shown.

Side by side Swipe Overlay Before Width:  |  Height:  |  Size: 1.6 KiB After Width:  |  Height:  |  Size: 1.6 KiB

BIN

Tests/LibWeb/Ref/reference/images/meter-ref.png

View file

Binary file not shown.

Side by side Swipe Overlay Before Width:  |  Height:  |  Size: 1 KiB After Width:  |  Height:  |  Size: 1 KiB

BIN

Tests/LibWeb/Ref/reference/images/object-fit-position.png

View file

Binary file not shown.

Side by side Swipe Overlay Before Width:  |  Height:  |  Size: 507 KiB After Width:  |  Height:  |  Size: 548 KiB

BIN

Tests/LibWeb/Ref/reference/images/text-shadow-ref.png

View file

Binary file not shown.

Side by side Swipe Overlay Before Width:  |  Height:  |  Size: 45 KiB After Width:  |  Height:  |  Size: 45 KiB