1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:07:35 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -43,4 +43,4 @@ file threw exception: InvalidStateError: valueAsNumber: Invalid input type used
submit threw exception: InvalidStateError: valueAsNumber: Invalid input type used
image threw exception: InvalidStateError: valueAsNumber: Invalid input type used
reset threw exception: InvalidStateError: valueAsNumber: Invalid input type used
button threw exception: InvalidStateError: valueAsNumber: Invalid input type used
button threw exception: InvalidStateError: valueAsNumber: Invalid input type used

View file

@ -14,4 +14,4 @@ true
1
true
[object ArrayBuffer]
ERROR: DataCloneError: Cannot serialize Symbol
ERROR: DataCloneError: Cannot serialize Symbol

View file

@ -5,4 +5,4 @@ false
123
123.456
9007199254740991
This is a string
This is a string

View file

@ -3,4 +3,4 @@ true
true
true
true
true
true

View file

@ -1,2 +1,2 @@
true
true
true

View file

@ -3,4 +3,4 @@
[object WindowProperties]
[object EventTarget]
[object Object]
null
null