RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:57:46 +00:00
Code Issues Activity Actions

LibWeb: Remove rounding division for CSSPixels

Browse source 
Reverts 98926b487c
that regressed: block-and-inline/small-percentage-margin.html
(thrashing layout while window resizing)

Fixes https://github.com/SerenityOS/serenity/issues/22610
This commit is contained in:
Aliaksandr Kalenik 2024-01-06 06:08:23 +01:00 • committed by Andreas Kling
parent 7db8b206a8
commit e7eaf3b566
32 changed files with 257 additions and 245 deletions
Download patch file Download diff file Expand all files Collapse all files

58
Tests/LibWeb/Layout/expected/table/fixed-layout-percentage-width.txt
View file

@ -5,67 +5,67 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <table> at (9,9) content-size 598x42.9375 table-box [TFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tbody> at (9,9) content-size 598.015625x42.9375 table-row-group children: not-inline
Box <tr> at (9,9) content-size 598.015625x21.46875 table-row children: not-inline
Box <tbody> at (9,9) content-size 597.96875x42.9375 table-row-group children: not-inline
Box <tr> at (9,9) content-size 597.96875x21.46875 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,11) content-size 95.671875x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (11,11) content-size 95.65625x17.46875 table-cell [BFC] children: inline
line 0 width: 26.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [11,11 26.078125x17.46875]
"cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (110.671875,11) content-size 95.671875x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (110.65625,11) content-size 95.65625x17.46875 table-cell [BFC] children: inline
line 0 width: 26.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [110.671875,11 26.078125x17.46875]
frag 0 from TextNode start: 0, length: 4, rect: [110.65625,11 26.078125x17.46875]
"cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (210.34375,11) content-size 95.671875x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (210.3125,11) content-size 95.65625x17.46875 table-cell [BFC] children: inline
line 0 width: 94.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 12, rect: [210.34375,11 94.96875x17.46875]
frag 0 from TextNode start: 0, length: 12, rect: [210.3125,11 94.96875x17.46875]
"A table cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (310.015625,11) content-size 295x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (309.96875,11) content-size 295x17.46875 table-cell [BFC] children: inline
line 0 width: 94.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 12, rect: [310.015625,11 94.96875x17.46875]
frag 0 from TextNode start: 0, length: 12, rect: [309.96875,11 94.96875x17.46875]
"A table cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tr> at (9,30.46875) content-size 598.015625x21.46875 table-row children: not-inline
Box <tr> at (9,30.46875) content-size 597.96875x21.46875 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,32.46875) content-size 95.671875x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (11,32.46875) content-size 95.65625x17.46875 table-cell [BFC] children: inline
line 0 width: 26.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [11,32.46875 26.078125x17.46875]
"cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (110.671875,32.46875) content-size 95.671875x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (110.65625,32.46875) content-size 95.65625x17.46875 table-cell [BFC] children: inline
line 0 width: 26.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [110.671875,32.46875 26.078125x17.46875]
frag 0 from TextNode start: 0, length: 4, rect: [110.65625,32.46875 26.078125x17.46875]
"cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (210.34375,32.46875) content-size 95.671875x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (210.3125,32.46875) content-size 95.65625x17.46875 table-cell [BFC] children: inline
line 0 width: 94.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 12, rect: [210.34375,32.46875 94.96875x17.46875]
frag 0 from TextNode start: 0, length: 12, rect: [210.3125,32.46875 94.96875x17.46875]
"A table cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (310.015625,32.46875) content-size 295x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (309.96875,32.46875) content-size 295x17.46875 table-cell [BFC] children: inline
line 0 width: 94.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 12, rect: [310.015625,32.46875 94.96875x17.46875]
frag 0 from TextNode start: 0, length: 12, rect: [309.96875,32.46875 94.96875x17.46875]
"A table cell"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -77,23 +77,23 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x44.9375]
PaintableWithLines (TableWrapper(anonymous)) [8,8 600x44.9375]
PaintableBox (Box<TABLE>) [8,8 600x44.9375] overflow: [9,9 598.015625x42.9375]
PaintableBox (Box<TBODY>) [9,9 598.015625x42.9375]
PaintableBox (Box<TR>) [9,9 598.015625x21.46875]
PaintableWithLines (BlockContainer<TD>) [9,9 99.671875x21.46875]
PaintableBox (Box<TABLE>) [8,8 600x44.9375]
PaintableBox (Box<TBODY>) [9,9 597.96875x42.9375]
PaintableBox (Box<TR>) [9,9 597.96875x21.46875]
PaintableWithLines (BlockContainer<TD>) [9,9 99.65625x21.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [108.671875,9 99.671875x21.46875]
PaintableWithLines (BlockContainer<TD>) [108.65625,9 99.65625x21.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [208.34375,9 99.671875x21.46875]
PaintableWithLines (BlockContainer<TD>) [208.3125,9 99.65625x21.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [308.015625,9 299x21.46875]
PaintableWithLines (BlockContainer<TD>) [307.96875,9 299x21.46875]
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [9,30.46875 598.015625x21.46875]
PaintableWithLines (BlockContainer<TD>) [9,30.46875 99.671875x21.46875]
PaintableBox (Box<TR>) [9,30.46875 597.96875x21.46875]
PaintableWithLines (BlockContainer<TD>) [9,30.46875 99.65625x21.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [108.671875,30.46875 99.671875x21.46875]
PaintableWithLines (BlockContainer<TD>) [108.65625,30.46875 99.65625x21.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [208.34375,30.46875 99.671875x21.46875]
PaintableWithLines (BlockContainer<TD>) [208.3125,30.46875 99.65625x21.46875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [308.015625,30.46875 299x21.46875]
PaintableWithLines (BlockContainer<TD>) [307.96875,30.46875 299x21.46875]
TextPaintable (TextNode<#text>)

12
Tests/LibWeb/Layout/expected/table/row-outer-size-with-computed-size.txt
View file

@ -9,7 +9,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <tr> at (10,10) content-size 43.21875x9.734375 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,14.875) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <td> at (11,14.859375) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (16,12) content-size 37.21875x17.46875 table-cell [BFC] children: inline
@ -27,7 +27,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <tr> at (10,21.734375) content-size 43.21875x9.734375 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (11,26.609375) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <td> at (11,26.59375) content-size 0x0 table-cell [BFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -38,11 +38,11 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x25.46875]
PaintableWithLines (TableWrapper(anonymous)) [8,8 49.21875x25.46875]
PaintableBox (Box<TABLE>) [8,8 49.21875x25.46875]
PaintableBox (Box<TBODY>) [8,8 43.21875x19.46875] overflow: [8,8 47.21875x23.484375]
PaintableBox (Box<TBODY>) [8,8 43.21875x19.46875] overflow: [8,8 47.21875x23.46875]
PaintableBox (Box<TR>) [10,10 43.21875x9.734375] overflow: [10,10 45.21875x21.46875]
PaintableWithLines (BlockContainer<TD>) [10,10 2x9.75]
PaintableWithLines (BlockContainer<TD>) [10,10 2x9.71875]
PaintableWithLines (BlockContainer<TD>) [14,10 41.21875x21.46875]
InlinePaintable (InlineNode<A>)
TextPaintable (TextNode<#text>)
PaintableBox (Box<TR>) [10,21.734375 43.21875x9.734375] overflow: [10,21.734375 43.21875x9.75]
PaintableWithLines (BlockContainer<TD>) [10,21.734375 2x9.75]
PaintableBox (Box<TR>) [10,21.734375 43.21875x9.734375]
PaintableWithLines (BlockContainer<TD>) [10,21.734375 2x9.71875]

16
Tests/LibWeb/Layout/expected/table/row-span-and-nested-tables.txt
View file

@ -15,9 +15,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <tr> at (11,11) content-size 67.828125x54.203125 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (17,29.375) content-size 11.5625x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (17,29.359375) content-size 11.5625x17.46875 table-cell [BFC] children: inline
line 0 width: 11.5625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [17,29.375 11.5625x17.46875]
frag 0 from TextNode start: 0, length: 1, rect: [17,29.359375 11.5625x17.46875]
"X"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -79,9 +79,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <tr> at (11,67.203125) content-size 67.828125x54.203125 table-row children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
BlockContainer <td> at (17,85.578125) content-size 11.5625x17.46875 table-cell [BFC] children: inline
BlockContainer <td> at (17,85.5625) content-size 11.5625x17.46875 table-cell [BFC] children: inline
line 0 width: 11.09375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [17,85.578125 11.09375x17.46875]
frag 0 from TextNode start: 0, length: 1, rect: [17,85.5625 11.09375x17.46875]
"Y"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) children: inline
@ -100,9 +100,9 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer(anonymous)) [8,8 784x0]
PaintableWithLines (TableWrapper(anonymous)) [8,8 75.828125x116.40625]
PaintableBox (Box<TABLE>) [8,8 75.828125x116.40625]
PaintableBox (Box<TBODY>) [9,9 67.828125x108.40625] overflow: [9,9 71.828125x112.421875]
PaintableBox (Box<TBODY>) [9,9 67.828125x108.40625] overflow: [9,9 71.828125x112.40625]
PaintableBox (Box<TR>) [11,11 67.828125x54.203125] overflow: [11,11 69.828125x110.40625]
PaintableWithLines (BlockContainer<TD>) [11,11 23.5625x54.21875]
PaintableWithLines (BlockContainer<TD>) [11,11 23.5625x54.1875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<TD>) [36.5625,11 44.265625x110.40625]
PaintableWithLines (BlockContainer(anonymous)) [42.5625,17 32.265625x0]
@ -122,7 +122,7 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer(anonymous)) [42.5625,17 0x0]
PaintableWithLines (BlockContainer(anonymous)) [42.5625,17 0x0]
PaintableWithLines (BlockContainer(anonymous)) [42.5625,115.40625 32.265625x0]
PaintableBox (Box<TR>) [11,67.203125 67.828125x54.203125] overflow: [11,67.203125 67.828125x54.21875]
PaintableWithLines (BlockContainer<TD>) [11,67.203125 23.5625x54.21875]
PaintableBox (Box<TR>) [11,67.203125 67.828125x54.203125]
PaintableWithLines (BlockContainer<TD>) [11,67.203125 23.5625x54.1875]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,124.40625 784x0]