RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:07:45 +00:00
Code Issues Activity Actions

LibWeb: Remove rounding division for CSSPixels

Browse source 
Reverts 98926b487c
that regressed: block-and-inline/small-percentage-margin.html
(thrashing layout while window resizing)

Fixes https://github.com/SerenityOS/serenity/issues/22610
This commit is contained in:
Aliaksandr Kalenik 2024-01-06 06:08:23 +01:00 • committed by Andreas Kling
parent 7db8b206a8
commit e7eaf3b566
32 changed files with 257 additions and 245 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/PixelUnits.h
View file

@ -288,14 +288,6 @@ constexpr CSSPixels operator*(T left, CSSPixels right) { return CSSPixels(left)
inline float operator*(float left, CSSPixels right) { return right.to_float() * left; }
inline double operator*(double left, CSSPixels right) { return right.to_double() * left; }
template<Integral T>
constexpr static T rounding_divide(T dividend, T divisor)
{
if ((dividend < 0) == (divisor < 0))
return (dividend + (divisor / 2)) / divisor;
return (dividend - (divisor / 2)) / divisor;
}
class CSSPixelFraction {
public:
constexpr CSSPixelFraction(CSSPixels numerator, CSSPixels denominator)
@ -321,7 +313,7 @@ public:
{
i64 wide_value = m_numerator.raw_value();
wide_value <<= CSSPixels::fractional_bits;
wide_value = rounding_divide<i64>(wide_value, m_denominator.raw_value());
wide_value /= m_denominator.raw_value();
return CSSPixels::from_raw(AK::clamp_to<int>(wide_value));
}
@ -373,7 +365,7 @@ constexpr CSSPixels CSSPixels::operator*(CSSPixelFraction const& other) const
{
i64 wide_value = raw_value();
wide_value *= other.numerator().raw_value();
wide_value = rounding_divide<i64>(wide_value, other.denominator().raw_value());
wide_value /= other.denominator().raw_value();
return CSSPixels::from_raw(AK::clamp_to<int>(wide_value));
}
@ -385,7 +377,7 @@ constexpr CSSPixels CSSPixels::operator/(CSSPixelFraction const& other) const
{
i64 wide_value = raw_value();
wide_value *= other.denominator().raw_value();
wide_value = rounding_divide<i64>(wide_value, other.numerator().raw_value());
wide_value /= other.numerator().raw_value();
return CSSPixels::from_raw(AK::clamp_to<int>(wide_value));
}