RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:37:45 +00:00
Code Issues Activity Actions

LibWeb: Fix multi-line flex column layouts with auto height on container

Browse source 
When sizing a flex container with flex-direction:column under a
max-content height constraint, we were incorrectly truncating the
infinite available height to 0 when collecting flex items into lines.

This caused us to put every flex item in its own flex line, which is the
complete opposite of what we want during max-content intrinsic sizing,
as the layout would grow wide but not tall.
This commit is contained in:
Andreas Kling 2023-04-16 19:48:40 +02:00
parent b9b6037d2b
commit e7f5b5a2f3
3 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Tests/LibWeb/Layout/expected/flex/multi-line-column-container-with-automatic-height.txt Normal file
View file

@ -0,0 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x176 children: not-inline
BlockContainer <body> at (10,10) content-size 780x158 children: not-inline
Box <div.flexbox> at (11,11) content-size 200x156 flex-container(column) children: not-inline
BlockContainer <div> at (12,12) content-size 50x50 flex-item children: not-inline
BlockContainer <div> at (12,64) content-size 50x50 flex-item children: not-inline
BlockContainer <div> at (12,116) content-size 50x50 flex-item children: not-inline