RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 14:18:11 +00:00
Code Issues Activity Actions

LibWeb: Explicitly set the audio element playback position after seeking

Browse source 
The audio element behaves a bit differently than the video element in
that the audio element drives itself on a timer (as opposed to LibVideo
notifying the video element when a frame is available). So if an audio
element is paused while seeking, we wouldn't receive an updated playback
position until the element is unpaused.

This fixes an issue where you would have to click the play button twice
to re-start an audio track after it reached the end.
This commit is contained in:
Timothy Flynn 2023-06-16 09:47:28 -04:00 • committed by Andreas Kling
parent 58478d572f
commit e81abbde7b
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/AudioTrack.cpp
View file

@ -98,6 +98,7 @@ void AudioTrack::seek(double position, MediaSeekMode seek_mode)
position = position / duration * static_cast<double>(m_loader->total_samples());
m_loader->seek(position).release_value_but_fixme_should_propagate_errors();
m_media_element->set_current_playback_position(this->position().to_milliseconds() / 1000.0);
}
void AudioTrack::update_volume()