From e81baa0464f1ace0513e348e746a2cc14660bd55 Mon Sep 17 00:00:00 2001 From: Lucas CHOLLET Date: Mon, 8 May 2023 12:19:22 -0400 Subject: [PATCH] LibGfx/JPEG: Discard the correct number of bytes This path has never been tested as it requires a non-standard APP segment. We (un?)fortunately found one, and it exposed a silly bug. --- Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp index 0255394365..34a20d1f8e 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp @@ -1042,8 +1042,8 @@ static ErrorOr read_colour_encoding(Stream& stream, [[maybe_unused]] JPEGL auto const color_transform = TRY(stream.read_value()); if (bytes_to_read > 6) { - dbgln_if(JPEG_DEBUG, "Unread bytes in App14 segment: {}", bytes_to_read - 1); - TRY(stream.discard(bytes_to_read - 1)); + dbgln_if(JPEG_DEBUG, "Unread bytes in App14 segment: {}", bytes_to_read - 6); + TRY(stream.discard(bytes_to_read - 6)); } switch (color_transform) {