RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:28:12 +00:00
Code Issues Activity Actions

Kernel: Don't assume paths to children PID directories in ProcFS code

Browse source 
Instead of using absolute paths which is considered an abstraction layer
violation between the kernel and userspace, let's not hardcode the path
to children PID directories but instead we can use relative path links
to them.
This commit is contained in:
Liav A 2022-10-14 22:19:14 +03:00 • committed by Andrew Kaster
parent 092b33c96e
commit e81cf66784
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/ProcessSpecificExposed.cpp
View file

@ -112,7 +112,7 @@ ErrorOr<NonnullLockRefPtr<Inode>> Process::lookup_children_directory(ProcFS cons
ErrorOr<size_t> Process::procfs_get_child_proccess_link(ProcessID child_pid, KBufferBuilder& builder) const
{
TRY(builder.appendff("/proc/{}", child_pid.value()));
TRY(builder.appendff("../../{}", child_pid.value()));
return builder.length();
}