RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 10:08:10 +00:00
Code Issues Activity Actions

LibWeb: Fix off-by-one in CSS calc() "negate" operation

Browse source 
When negating a number, we should subtract it from 0, not 1. :^)
This commit is contained in:
Andreas Kling 2023-05-16 16:57:12 +02:00
parent 587c44cfbb
commit e81d4ca1ac
7 changed files with 38 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/CSS/StyleValues/CalculatedStyleValue.cpp
View file

@ -583,22 +583,22 @@ void CalculatedStyleValue::CalculationResult::negate()
{
m_value.visit(
[&](Number const& number) {
m_value = Number { number.type(), 1 - number.value() };
m_value = Number { number.type(), 0 - number.value() };
},
[&](Angle const& angle) {
m_value = Angle { 1 - angle.raw_value(), angle.type() };
m_value = Angle { 0 - angle.raw_value(), angle.type() };
},
[&](Frequency const& frequency) {
m_value = Frequency { 1 - frequency.raw_value(), frequency.type() };
m_value = Frequency { 0 - frequency.raw_value(), frequency.type() };
},
[&](Length const& length) {
m_value = Length { 1 - length.raw_value(), length.type() };
m_value = Length { 0 - length.raw_value(), length.type() };
},
[&](Time const& time) {
m_value = Time { 1 - time.raw_value(), time.type() };
m_value = Time { 0 - time.raw_value(), time.type() };
},
[&](Percentage const& percentage) {
m_value = Percentage { 1 - percentage.value() };
m_value = Percentage { 0 - percentage.value() };
});
}