RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:17:44 +00:00
Code Issues Activity Actions

LibWeb: Use the right DOM node when placing cursor on double-click

Browse source 
This fixes a null pointer dereference when double-clicking in text
content on some pages.
This commit is contained in:
Andreas Kling 2023-05-23 07:42:01 +02:00
parent 80d6330a26
commit e83681ee34
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -597,6 +597,8 @@ bool EventHandler::handle_doubleclick(CSSPixelPoint position, unsigned button, u
auto const& hit_layout_node = hit_paintable->layout_node();
if (!hit_layout_node.is_text_node())
return true;
auto& hit_dom_node = verify_cast<DOM::Text>(*hit_paintable->dom_node());
auto const& text_for_rendering = verify_cast<Layout::TextNode>(hit_layout_node).text_for_rendering();
int first_word_break_before = [&] {
@ -619,9 +621,9 @@ bool EventHandler::handle_doubleclick(CSSPixelPoint position, unsigned button, u
return text_for_rendering.length();
}();
m_browsing_context->set_cursor_position(DOM::Position(*paintable->dom_node(), first_word_break_after));
m_browsing_context->set_cursor_position(DOM::Position(hit_dom_node, first_word_break_after));
if (auto selection = node->document().get_selection()) {
(void)selection->set_base_and_extent(*paintable->dom_node(), first_word_break_before, *paintable->dom_node(), first_word_break_after);
(void)selection->set_base_and_extent(hit_dom_node, first_word_break_before, hit_dom_node, first_word_break_after);
}
}
}